YT-22846: Fix vptr race in TRoamingRequestControl

09883f9b14b10cfd69e95d7afb810a49aa054682

1 files changed, 8 insertions, 6 deletions

diff --git a/yt/yt/core/rpc/roaming_channel.cpp b/yt/yt/core/rpc/roaming_channel.cpp
index 93717ea4f1..d79ee7e35a 100644
--- a/yt/yt/core/rpc/roaming_channel.cpp
+++ b/yt/yt/core/rpc/roaming_channel.cpp
@@ -17,18 +17,19 @@ class TRoamingRequestControl
 {
 public:
     TRoamingRequestControl(
-        TFuture<IChannelPtr> asyncChannel,
         IClientRequestPtr request,
         IClientResponseHandlerPtr responseHandler,
         const TSendOptions& options)
         : Request_(std::move(request))
         , ResponseHandler_(std::move(responseHandler))
         , Options_(options)
-        , StartTime_(TInstant::Now())
+    { }
+
+    void Initialize(TFuture<IChannelPtr> asyncChannel)
     {
         if (Options_.Timeout) {
             asyncChannel = asyncChannel.WithTimeout(*Options_.Timeout, TFutureTimeoutOptions{
-                .Error = TError("Error getting channel")
+                .Error = TError("Error getting channel"),
             });
         }
 
@@ -56,7 +57,7 @@ private:
     IClientRequestPtr Request_;
     IClientResponseHandlerPtr ResponseHandler_;
     const TSendOptions Options_;
-    const TInstant StartTime_;
+    const TInstant StartTime_ = TInstant::Now();
 
     std::atomic<bool> Semaphore_ = false;
 
@@ -160,11 +161,12 @@ public:
             }
         }
 
-        return New<TRoamingRequestControl>(
-            std::move(asyncChannel),
+        auto control = New<TRoamingRequestControl>(
             std::move(request),
             std::move(responseHandler),
             options);
+        control->Initialize(std::move(asyncChannel));
+        return control;
     }
 
     void Terminate(const TError& error) override