diff options
author | a-romanov <Anton.Romanov@ydb.tech> | 2023-06-20 12:06:40 +0300 |
---|---|---|
committer | a-romanov <Anton.Romanov@ydb.tech> | 2023-06-20 12:06:40 +0300 |
commit | 260dfc6bf9796ddc322e117e730a624f2418a767 (patch) | |
tree | fa20014fa33eacc8da214975543d7b5b8b633a39 | |
parent | 1472e974beccfca7e3292b83e9197d870e328064 (diff) | |
download | ydb-260dfc6bf9796ddc322e117e730a624f2418a767.tar.gz |
YQL-15941 Fix warning in round.
-rw-r--r-- | ydb/library/yql/minikql/comp_nodes/mkql_round.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_round.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_round.cpp index 77c334f282..57eba4fcfe 100644 --- a/ydb/library/yql/minikql/comp_nodes/mkql_round.cpp +++ b/ydb/library/yql/minikql/comp_nodes/mkql_round.cpp @@ -32,16 +32,16 @@ public: } NUdf::TUnboxedValuePod DoCalculate(TComputationContext& ctx) const { - auto value = Source->GetValue(ctx).Get<From>(); - auto toMin = std::numeric_limits<To>::min(); - auto toMax = std::numeric_limits<To>::max(); + const auto value = Source->GetValue(ctx).Get<From>(); + constexpr auto toMin = std::numeric_limits<To>::min(); + constexpr auto toMax = std::numeric_limits<To>::max(); if constexpr (std::is_signed<From>::value && std::is_unsigned<To>::value) { if (value < 0) { return Down ? TUnboxedValuePod() : TUnboxedValuePod(toMin); } - if (value > toMax) { + if (static_cast<std::make_unsigned_t<From>>(value) > toMax) { return Down ? TUnboxedValuePod(toMax) : TUnboxedValuePod(); } @@ -49,7 +49,7 @@ public: } if constexpr (std::is_unsigned<From>::value && std::is_signed<To>::value) { - if (value > toMax) { + if (value > static_cast<std::make_unsigned_t<To>>(toMax)) { return Down ? TUnboxedValuePod(toMax) : TUnboxedValuePod(); } |