aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorspeedwagon <speedwagon@yandex-team.com>2023-03-02 20:43:57 +0300
committerspeedwagon <speedwagon@yandex-team.com>2023-03-02 20:43:57 +0300
commit24ab5527003dfee650f86124bc52ecb437f65aba (patch)
tree8258ed45e97a353c8d46e4a928ea44a582904a75
parent53460b26d181bc31325350bf939e883ed3a85fae (diff)
downloadydb-24ab5527003dfee650f86124bc52ecb437f65aba.tar.gz
Fix import tests for pydebug
Fixed: ``` arcadia/library/python/testing/import_test/import_test.py:31: [E731] do not assign a lambda expression, use a def arcadia/library/python/testing/import_test/import_test.py:33: [E731] do not assign a lambda expression, use a def arcadia/library/python/testing/import_test/import_test.py:51: [E731] do not assign a lambda expression, use a def arcadia/library/python/testing/import_test/import_test.py:71: [E741] ambiguous variable name 'l' arcadia/library/python/testing/import_test/import_test.py:96: [E722] do not use bare 'except' arcadia/library/python/testing/import_test/import_test.py:151: [E722] do not use bare 'except' ```
-rw-r--r--library/python/testing/import_test/import_test.py18
1 files changed, 11 insertions, 7 deletions
diff --git a/library/python/testing/import_test/import_test.py b/library/python/testing/import_test/import_test.py
index 9d187a3d64..17ceda858f 100644
--- a/library/python/testing/import_test/import_test.py
+++ b/library/python/testing/import_test/import_test.py
@@ -28,9 +28,12 @@ def check_imports(no_check=(), extra=(), skip_func=None, py_main=None):
"from import_test import test_imports" to your python test source file.
"""
- str_ = lambda s: s
if not isinstance(b'', str):
- str_ = lambda s: s.decode('UTF-8')
+ def str_(s):
+ return s.decode('UTF-8')
+ else:
+ def str_(s):
+ return s
exceptions = list(no_check)
for key, _ in __res.iter_keys(b'py/no_check_imports/'):
@@ -48,7 +51,8 @@ def check_imports(no_check=(), extra=(), skip_func=None, py_main=None):
failed = []
import_times = {}
- norm = lambda s: s[:-9] if s.endswith('.__init__') else s
+ def norm(s):
+ return (s[:-9] if s.endswith('.__init__') else s)
modules = sys.extra_modules | set(extra)
modules = sorted(modules, key=norm)
@@ -68,8 +72,8 @@ def check_imports(no_check=(), extra=(), skip_func=None, py_main=None):
def print_backtrace_marked(e):
tb_exc = traceback.format_exception(*e)
for item in tb_exc:
- for l in item.splitlines():
- print('FAIL:', l, file=sys.stderr)
+ for line in item.splitlines():
+ print('FAIL:', line, file=sys.stderr)
try:
print('TRY', module)
@@ -93,7 +97,7 @@ def check_imports(no_check=(), extra=(), skip_func=None, py_main=None):
print_backtrace_marked(sys.exc_info())
failed.append('{}: {}'.format(module, e))
- except:
+ except BaseException:
e = sys.exc_info()
print('FAIL:', module, e, file=sys.stderr)
print_backtrace_marked(e)
@@ -148,5 +152,5 @@ def main():
try:
check_imports(no_check=skip_names, py_main=py_main_module)
- except:
+ except Exception:
sys.exit(1)