aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniil Cherednik <dcherednik@ydb.tech>2023-06-23 17:40:16 +0000
committerdcherednik <dcherednik@ydb.tech>2023-06-23 20:40:16 +0300
commit2173d52a5add689a6791d41222f2fb5f6fc67033 (patch)
treee8e1c2a81fc4557dd4204325d35cb9e65f88e75a
parent7e85d9e485236825f25078d28582730a26f05a0e (diff)
downloadydb-2173d52a5add689a6791d41222f2fb5f6fc67033.tar.gz
Remove unused TEvDiscardSnapshot event field.
Remove unused TEvDiscardSnapshot event field. Pull Request resolved: #256
-rw-r--r--ydb/core/kqp/rm_service/kqp_snapshot_manager.cpp5
-rw-r--r--ydb/core/kqp/rm_service/kqp_snapshot_manager.h5
-rw-r--r--ydb/core/kqp/session_actor/kqp_session_actor.cpp2
3 files changed, 4 insertions, 8 deletions
diff --git a/ydb/core/kqp/rm_service/kqp_snapshot_manager.cpp b/ydb/core/kqp/rm_service/kqp_snapshot_manager.cpp
index a7a80150ef..c68b621829 100644
--- a/ydb/core/kqp/rm_service/kqp_snapshot_manager.cpp
+++ b/ydb/core/kqp/rm_service/kqp_snapshot_manager.cpp
@@ -232,9 +232,8 @@ private:
Become(&TThis::StateCleanup);
}
- void HandleRefreshing(TEvKqpSnapshot::TEvDiscardSnapshot::TPtr& ev) {
- const auto* msg = ev->Get();
- LOG_W("KqpSnapshotManager: discarding snapshot; our snapshot: " << Snapshot << " got: " << msg->Snapshot << " shutting down");
+ void HandleRefreshing(TEvKqpSnapshot::TEvDiscardSnapshot::TPtr&) {
+ LOG_W("KqpSnapshotManager: discarding snapshot; our snapshot: " << Snapshot << " shutting down");
SendDiscard();
PassAway();
}
diff --git a/ydb/core/kqp/rm_service/kqp_snapshot_manager.h b/ydb/core/kqp/rm_service/kqp_snapshot_manager.h
index 995d16c085..cfbacd21e2 100644
--- a/ydb/core/kqp/rm_service/kqp_snapshot_manager.h
+++ b/ydb/core/kqp/rm_service/kqp_snapshot_manager.h
@@ -45,10 +45,7 @@ struct TEvKqpSnapshot {
};
struct TEvDiscardSnapshot : public TEventLocal<TEvDiscardSnapshot, TKqpSnapshotEvents::EvDiscardSnapshot> {
- explicit TEvDiscardSnapshot(const IKqpGateway::TKqpSnapshot& snapshot)
- : Snapshot(snapshot)
- {}
- const IKqpGateway::TKqpSnapshot Snapshot;
+ TEvDiscardSnapshot() = default;
};
};
diff --git a/ydb/core/kqp/session_actor/kqp_session_actor.cpp b/ydb/core/kqp/session_actor/kqp_session_actor.cpp
index 83b35a1ba7..0e797f007a 100644
--- a/ydb/core/kqp/session_actor/kqp_session_actor.cpp
+++ b/ydb/core/kqp/session_actor/kqp_session_actor.cpp
@@ -538,7 +538,7 @@ public:
void DiscardPersistentSnapshot(const IKqpGateway::TKqpSnapshotHandle& handle) {
if (handle.ManagingActor) { // persistent snapshot was acquired
- Send(handle.ManagingActor, new TEvKqpSnapshot::TEvDiscardSnapshot(handle.Snapshot));
+ Send(handle.ManagingActor, new TEvKqpSnapshot::TEvDiscardSnapshot());
}
}