diff options
author | dmasloff <74042473+dmasloff@users.noreply.github.com> | 2024-08-15 15:27:06 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-08-15 15:27:06 +0300 |
commit | 1f7017f69a32b9861dcbfed800ebb69231a1d318 (patch) | |
tree | a28bc4b921ba41f9cbab4ec108e2d28b38100ae2 | |
parent | 216af268f259e626b7e97303d104be74a7774286 (diff) | |
download | ydb-1f7017f69a32b9861dcbfed800ebb69231a1d318.tar.gz |
Set SpacesInLineCommentPrefix to 1 (#7782)
8 files changed, 29 insertions, 29 deletions
diff --git a/ydb/library/yql/providers/generic/actors/ut/yql_generic_lookup_actor_ut.cpp b/ydb/library/yql/providers/generic/actors/ut/yql_generic_lookup_actor_ut.cpp index c57667366e1..b824b4c4d5c 100644 --- a/ydb/library/yql/providers/generic/actors/ut/yql_generic_lookup_actor_ut.cpp +++ b/ydb/library/yql/providers/generic/actors/ut/yql_generic_lookup_actor_ut.cpp @@ -30,7 +30,7 @@ Y_UNIT_TEST_SUITE(GenericProviderLookupActor) { return result; } - //Simple actor to call IDqAsyncLookupSource::AsyncLookup from an actor system's thread + // Simple actor to call IDqAsyncLookupSource::AsyncLookup from an actor system's thread class TCallLookupActor: public TActorBootstrapped<TCallLookupActor> { public: TCallLookupActor( @@ -135,7 +135,7 @@ Y_UNIT_TEST_SUITE(GenericProviderLookupActor) { .AddResponse( MakeRecordBatch( MakeArray<arrow::UInt64Builder, uint64_t>("id", {0, 1, 2}, arrow::uint64()), - MakeArray<arrow::UInt64Builder, uint64_t>("optional_id", {100, 101, 103}, arrow::uint64()), //the last value is intentially wrong + MakeArray<arrow::UInt64Builder, uint64_t>("optional_id", {100, 101, 103}, arrow::uint64()), // the last value is intentially wrong MakeArray<arrow::StringBuilder, std::string>("string_value", {"a", "b", "c"}, arrow::utf8()) ), NewSuccess() @@ -184,7 +184,7 @@ Y_UNIT_TEST_SUITE(GenericProviderLookupActor) { request.emplace(std::move(key), NYql::NUdf::TUnboxedValue{}); } - guard.Release(); //let actors use alloc + guard.Release(); // let actors use alloc auto callLookupActor = new TCallLookupActor(alloc, lookupSource, std::move(request)); runtime.Register(callLookupActor); @@ -213,4 +213,4 @@ Y_UNIT_TEST_SUITE(GenericProviderLookupActor) { } } -} //Y_UNIT_TEST_SUITE(GenericProviderLookupActor) +} // Y_UNIT_TEST_SUITE(GenericProviderLookupActor) diff --git a/ydb/library/yql/providers/generic/actors/yql_generic_base_actor.h b/ydb/library/yql/providers/generic/actors/yql_generic_base_actor.h index c38fa9c9f0d..ec7810ad163 100644 --- a/ydb/library/yql/providers/generic/actors/yql_generic_base_actor.h +++ b/ydb/library/yql/providers/generic/actors/yql_generic_base_actor.h @@ -10,7 +10,7 @@ namespace NYql::NDq { template <typename TDerived> class TGenericBaseActor: public NActors::TActorBootstrapped<TDerived> { - protected: //Events + protected: // Events // Event ids enum EEventIds: ui32 { EvBegin = EventSpaceBegin(NActors::TEvents::ES_PRIVATE), @@ -89,7 +89,7 @@ namespace NYql::NDq { NConnector::NApi::TError Error; }; - protected: //TODO move common logic here + protected: // TODO move common logic here }; } // namespace NYql::NDq diff --git a/ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp b/ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp index 956a0b7c30b..3c06767261c 100644 --- a/ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp +++ b/ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp @@ -44,11 +44,11 @@ namespace NYql::NDq { template <typename T> T ExtractFromConstFuture(const NThreading::TFuture<T>& f) { - //We want to avoid making a copy of data stored in a future. - //But there is no direct way to extract data from a const future5 - //So, we make a copy of the future, that is cheap. Then, extract the value from this copy. - //It destructs the value in the original future, but this trick is legal and documented here: - //https://docs.yandex-team.ru/arcadia-cpp/cookbook/concurrency + // We want to avoid making a copy of data stored in a future. + // But there is no direct way to extract data from a const future5 + // So, we make a copy of the future, that is cheap. Then, extract the value from this copy. + // It destructs the value in the original future, but this trick is legal and documented here: + // https://docs.yandex-team.ru/arcadia-cpp/cookbook/concurrency return NThreading::TFuture<T>(f).ExtractValueSync(); } @@ -112,7 +112,7 @@ namespace NYql::NDq { static constexpr char ActorName[] = "GENERIC_PROVIDER_LOOKUP_ACTOR"; - private: //IDqAsyncLookupSource + private: // IDqAsyncLookupSource size_t GetMaxSupportedKeysInRequest() const override { return MaxKeysInRequest; } @@ -121,7 +121,7 @@ namespace NYql::NDq { CreateRequest(std::move(request)); } - private: //events + private: // events STRICT_STFUNC(StateFunc, hFunc(TEvListSplitsIterator, Handle); hFunc(TEvListSplitsPart, Handle); @@ -238,7 +238,7 @@ namespace NYql::NDq { void ProcessReceivedData(const NConnector::NApi::TReadSplitsResponse& resp) { Y_ABORT_UNLESS(resp.payload_case() == NConnector::NApi::TReadSplitsResponse::PayloadCase::kArrowIpcStreaming); auto guard = Guard(*Alloc); - NKikimr::NArrow::NSerialization::TSerializerContainer deser = NKikimr::NArrow::NSerialization::TSerializerContainer::GetDefaultSerializer(); //todo move to class' member + NKikimr::NArrow::NSerialization::TSerializerContainer deser = NKikimr::NArrow::NSerialization::TSerializerContainer::GetDefaultSerializer(); // todo move to class' member const auto& data = deser->Deserialize(resp.arrow_ipc_streaming()); Y_ABORT_UNLESS(data.ok()); const auto& value = data.ValueOrDie(); @@ -259,7 +259,7 @@ namespace NYql::NDq { (ColumnDestinations[j].first == EColumnDestination::Key ? keyItems : outputItems)[ColumnDestinations[j].second] = columns[j][i]; } if (auto* v = Request.FindPtr(key)) { - *v = std::move(output); //duplicates will be overwritten + *v = std::move(output); // duplicates will be overwritten } } } @@ -316,8 +316,8 @@ namespace NYql::NDq { NYql::NConnector::NApi::TDataSourceInstance GetDataSourceInstanceWithToken() const { auto dsi = LookupSource.data_source_instance(); - //Note: returned token may be stale and we have no way to check or recover here - //Consider to redesign ICredentialsProvider + // Note: returned token may be stale and we have no way to check or recover here + // Consider to redesign ICredentialsProvider TokenProvider->MaybeFillToken(dsi); return dsi; } @@ -361,13 +361,13 @@ namespace NYql::NDq { const NYql::Generic::TLookupSource LookupSource; const NKikimr::NMiniKQL::TStructType* const KeyType; const NKikimr::NMiniKQL::TStructType* const PayloadType; - const NKikimr::NMiniKQL::TStructType* const SelectResultType; //columns from KeyType + PayloadType + const NKikimr::NMiniKQL::TStructType* const SelectResultType; // columns from KeyType + PayloadType const NKikimr::NMiniKQL::THolderFactory& HolderFactory; const std::vector<std::pair<EColumnDestination, size_t>> ColumnDestinations; const size_t MaxKeysInRequest; std::atomic_bool InProgress; IDqAsyncLookupSource::TUnboxedValueMap Request; - NConnector::IReadSplitsStreamIterator::TPtr ReadSplitsIterator; //TODO move me to TEvReadSplitsPart + NConnector::IReadSplitsStreamIterator::TPtr ReadSplitsIterator; // TODO move me to TEvReadSplitsPart NKikimr::NMiniKQL::TKeyPayloadPairVector LookupResult; }; diff --git a/ydb/library/yql/providers/generic/actors/yql_generic_read_actor.cpp b/ydb/library/yql/providers/generic/actors/yql_generic_read_actor.cpp index fa58560997d..0aa6c0faa15 100644 --- a/ydb/library/yql/providers/generic/actors/yql_generic_read_actor.cpp +++ b/ydb/library/yql/providers/generic/actors/yql_generic_read_actor.cpp @@ -27,11 +27,11 @@ namespace NYql::NDq { template <typename T> T ExtractFromConstFuture(const NThreading::TFuture<T>& f) { - //We want to avoid making a copy of data stored in a future. - //But there is no direct way to extract data from a const future - //So, we make a copy of the future, that is cheap. Then, extract the value from this copy. - //It destructs the value in the original future, but this trick is legal and documented here: - //https://docs.yandex-team.ru/arcadia-cpp/cookbook/concurrency + // We want to avoid making a copy of data stored in a future. + // But there is no direct way to extract data from a const future + // So, we make a copy of the future, that is cheap. Then, extract the value from this copy. + // It destructs the value in the original future, but this trick is legal and documented here: + // https://docs.yandex-team.ru/arcadia-cpp/cookbook/concurrency return NThreading::TFuture<T>(f).ExtractValueSync(); } diff --git a/ydb/library/yql/providers/generic/actors/yql_generic_token_provider.cpp b/ydb/library/yql/providers/generic/actors/yql_generic_token_provider.cpp index 55ff0e53db1..ec669efc8bf 100644 --- a/ydb/library/yql/providers/generic/actors/yql_generic_token_provider.cpp +++ b/ydb/library/yql/providers/generic/actors/yql_generic_token_provider.cpp @@ -65,4 +65,4 @@ namespace NYql::NDq { } return std::make_unique<TGenericTokenProvider>(); } -} //namespace NYql::NDq +} // namespace NYql::NDq diff --git a/ydb/library/yql/providers/generic/actors/yql_generic_token_provider.h b/ydb/library/yql/providers/generic/actors/yql_generic_token_provider.h index c5f4d3331de..42fcd252fb3 100644 --- a/ydb/library/yql/providers/generic/actors/yql_generic_token_provider.h +++ b/ydb/library/yql/providers/generic/actors/yql_generic_token_provider.h @@ -12,7 +12,7 @@ namespace NYql::NDq { class TGenericTokenProvider { public: using TPtr = std::unique_ptr<TGenericTokenProvider>; - TGenericTokenProvider() = default; //No auth required + TGenericTokenProvider() = default; // No auth required TGenericTokenProvider(const TString& staticIamToken); TGenericTokenProvider( const TString& serviceAccountId, @@ -31,4 +31,4 @@ namespace NYql::NDq { const TString& staticIamToken, const TString& serviceAccountId, const TString& ServiceAccountIdSignature, const ISecuredServiceAccountCredentialsFactory::TPtr& credentialsFactory); -} //namespace NYql::NDq +} // namespace NYql::NDq diff --git a/ydb/library/yql/providers/generic/connector/libcpp/ut_helpers/test_creds.h b/ydb/library/yql/providers/generic/connector/libcpp/ut_helpers/test_creds.h index f3025de0705..cefd4a43c98 100644 --- a/ydb/library/yql/providers/generic/connector/libcpp/ut_helpers/test_creds.h +++ b/ydb/library/yql/providers/generic/connector/libcpp/ut_helpers/test_creds.h @@ -33,4 +33,4 @@ namespace NYql::NTestCreds { } }; -} //namespace NYql::NTestCreds +} // namespace NYql::NTestCreds diff --git a/ydb/library/yql/providers/generic/provider/yql_generic_settings.h b/ydb/library/yql/providers/generic/provider/yql_generic_settings.h index 07a19c5ce82..6d1f83c7e40 100644 --- a/ydb/library/yql/providers/generic/provider/yql_generic_settings.h +++ b/ydb/library/yql/providers/generic/provider/yql_generic_settings.h @@ -42,4 +42,4 @@ namespace NYql { THashMap<TString, TGenericClusterConfig> ClusterNamesToClusterConfigs; // cluster name -> cluster config THashMap<TString, TVector<TString>> DatabaseIdsToClusterNames; // database id -> cluster name }; -} //namespace NYql +} // namespace NYql |