summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIvan Nikolaev <[email protected]>2024-11-15 15:11:10 +0300
committerGitHub <[email protected]>2024-11-15 15:11:10 +0300
commit1e55f85595d75320bd1b85d8a1771882cd3d4327 (patch)
tree75202a94e9b9566f3ec7b50e40e9f64ce5fde675
parent4a0b2a78b59c55c7bf4391542302af0282ab9cce (diff)
Change TODO comments about pg types in minikql (#11651)
-rw-r--r--ydb/core/client/minikql_compile/yql_expr_minikql.cpp2
-rw-r--r--ydb/core/engine/kikimr_program_builder.cpp8
-rw-r--r--ydb/core/engine/minikql/minikql_engine_host.cpp2
-rw-r--r--ydb/core/engine/mkql_engine_flat_extfunc.cpp6
4 files changed, 9 insertions, 9 deletions
diff --git a/ydb/core/client/minikql_compile/yql_expr_minikql.cpp b/ydb/core/client/minikql_compile/yql_expr_minikql.cpp
index 56ad360b95e..b7d90a9aa7f 100644
--- a/ydb/core/client/minikql_compile/yql_expr_minikql.cpp
+++ b/ydb/core/client/minikql_compile/yql_expr_minikql.cpp
@@ -397,7 +397,7 @@ private:
switch (column->Type.GetTypeId()) {
case NScheme::NTypeIds::Pg: {
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
YQL_ENSURE(false, "pg types are not supported");
break;
}
diff --git a/ydb/core/engine/kikimr_program_builder.cpp b/ydb/core/engine/kikimr_program_builder.cpp
index ed68f1958ef..c6bbd266c72 100644
--- a/ydb/core/engine/kikimr_program_builder.cpp
+++ b/ydb/core/engine/kikimr_program_builder.cpp
@@ -23,7 +23,7 @@ TType* ValidateColumns(
rowTypeBuilder.Reserve(columns.size());
tagsBuilder.Reserve(columns.size());
for (auto& col : columns) {
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
MKQL_ENSURE(col.SchemeType.GetTypeId() != 0, "Null type is not allowed");
MKQL_ENSURE(col.SchemeType.GetTypeId() != NScheme::NTypeIds::Pg, "pg types are not supported");
TType* dataType;
@@ -108,7 +108,7 @@ void TUpdateRowBuilder::SetColumn(
ui32 columnId, NScheme::TTypeInfo expectedType,
TRuntimeNode value)
{
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
MKQL_ENSURE(expectedType.GetTypeId() != NScheme::NTypeIds::Pg, "pg types are not supported");
bool isOptional;
@@ -126,7 +126,7 @@ void TUpdateRowBuilder::InplaceUpdateColumn(
TRuntimeNode value,
EInplaceUpdateMode mode)
{
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
MKQL_ENSURE(expectedType.GetTypeId() != NScheme::NTypeIds::Pg, "pg types are not supported");
MKQL_ENSURE(AS_TYPE(TDataType, value)->GetSchemeType() == expectedType.GetTypeId(),
"Mismatch of column type");
@@ -214,7 +214,7 @@ TVector<TRuntimeNode> TKikimrProgramBuilder::FixKeysType(
MKQL_ENSURE(keyTypes.size() == row.size(), "Mismatch of key types count");
TVector<TRuntimeNode> tmp(row.size());
for (ui32 i = 0; i < row.size(); ++i) {
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
MKQL_ENSURE(keyTypes[i].GetTypeId() != NScheme::NTypeIds::Pg, "pg types are not supported");
tmp[i] = RewriteNullType(row[i], keyTypes[i].GetTypeId());
bool isOptional;
diff --git a/ydb/core/engine/minikql/minikql_engine_host.cpp b/ydb/core/engine/minikql/minikql_engine_host.cpp
index b03e1d622d7..a2375593827 100644
--- a/ydb/core/engine/minikql/minikql_engine_host.cpp
+++ b/ydb/core/engine/minikql/minikql_engine_host.cpp
@@ -498,7 +498,7 @@ public:
}
firstKey.AppendNoAlias((const char*)typeIds.data(), tuple.ColumnCount * sizeof(NScheme::TTypeId));
firstKey.AppendNoAlias(cells);
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
if (List.FirstKey) {
Y_DEBUG_ABORT_UNLESS(*List.FirstKey == firstKey);
diff --git a/ydb/core/engine/mkql_engine_flat_extfunc.cpp b/ydb/core/engine/mkql_engine_flat_extfunc.cpp
index d2e97d31e6a..f23fdbc9f23 100644
--- a/ydb/core/engine/mkql_engine_flat_extfunc.cpp
+++ b/ydb/core/engine/mkql_engine_flat_extfunc.cpp
@@ -28,7 +28,7 @@ namespace {
}
const auto literal = AS_VALUE(TDataLiteral, data);
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
auto typeInfo = NScheme::TTypeInfo(literal->GetType()->GetSchemeType());
return MakeCell(typeInfo, literal->AsValue(), env, false);
}
@@ -638,14 +638,14 @@ namespace {
keyColumnsCount = partKeyColumnsCount;
for (ui32 i = 0; i < partKeyColumnsCount; ++i) {
auto partType = ReadUnaligned<NUdf::TDataTypeId>(partTypes + i * sizeof(NUdf::TDataTypeId));
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
types.push_back(NScheme::TTypeInfo(partType));
}
} else {
MKQL_ENSURE(keyColumnsCount == partKeyColumnsCount, "Mismatch of key columns count");
for (ui32 i = 0; i < keyColumnsCount; ++i) {
auto partType = ReadUnaligned<NUdf::TDataTypeId>(partTypes + i * sizeof(NUdf::TDataTypeId));
- // TODO: support pg types
+ // no need to support pg types in the deprecated minikql engine
MKQL_ENSURE(partType == types[i].GetTypeId(), "Mismatch of key columns type");
}
}