diff options
| author | zaverden <[email protected]> | 2024-07-05 12:15:03 +0300 |
|---|---|---|
| committer | zaverden <[email protected]> | 2024-07-05 12:29:47 +0300 |
| commit | 1ab14cb88b4c19d9745a90d7485ea366f0555244 (patch) | |
| tree | 29c1b4afc4f37ac3d2dacd0759cc1fe4525daed6 | |
| parent | 6698911ac2668913f97e09abecb8e014a44d3d7b (diff) | |
chore: review rules for FBP code to cover ya_make_team
38a89b2eb72ccf52b7112dcbc98bbdb74d765cec
| -rw-r--r-- | build/conf/ts/a.yaml | 26 | ||||
| -rw-r--r-- | build/plugins/lib/nots/a.yaml | 27 |
2 files changed, 39 insertions, 14 deletions
diff --git a/build/conf/ts/a.yaml b/build/conf/ts/a.yaml index c1c719d33b7..5b641f8e8a5 100644 --- a/build/conf/ts/a.yaml +++ b/build/conf/ts/a.yaml @@ -4,18 +4,26 @@ title: Frontend build platform build/conf/ts arcanum: review: auto_assign: true - # Хотим из двух шипов от разных команд только один - min_approvers_count: 1 groups: - name: fbp_team roles: frontend_build_platform:developer - name: ya_make_team roles: ya_make:developer rules: - - reviewers: - - name: fbp_team - assign: 3 - ship: 1 - - name: ya_make_team - assign: 1 - ship: 1 + # Если изменения от команды ya_make, то ревью на них + # FBP добавляется, чтобы они были в курсе, как владельцы кода + - authors: ya_make:developer + reviewers: + - name: ya_make_team + assign: 1 + ship: 1 + ignore_self_ship: false + - name: fbp_team + assign: 5 + ship: 0 + # Если изменения от кого-то стороннего, то ревью на FBP + - authors: "!ya_make:developer" + reviewers: + name: fbp_team + assign: 5 + ship: 1
\ No newline at end of file diff --git a/build/plugins/lib/nots/a.yaml b/build/plugins/lib/nots/a.yaml index 71c2f18ba82..d8c331789a1 100644 --- a/build/plugins/lib/nots/a.yaml +++ b/build/plugins/lib/nots/a.yaml @@ -4,9 +4,26 @@ title: Frontend build platform build/plugins/lib/nots arcanum: review: auto_assign: true + groups: + - name: fbp_team + roles: frontend_build_platform:developer + - name: ya_make_team + roles: ya_make:developer rules: - - reviewers: - name: developer - # мы хотим автоматом назначать всю команду - assign: 3 - ship: 1 + # Если изменения от команды ya_make, то ревью на них + # FBP добавляется, чтобы они были в курсе, как владельцы кода + - authors: ya_make:developer + reviewers: + - name: ya_make_team + assign: 1 + ship: 1 + ignore_self_ship: false + - name: fbp_team + assign: 5 + ship: 0 + # Если изменения от кого-то стороннего, то ревью на FBP + - authors: "!ya_make:developer" + reviewers: + name: fbp_team + assign: 5 + ship: 1
\ No newline at end of file |