diff options
author | ermolovd <ermolovd@yandex-team.com> | 2024-10-04 10:49:56 +0300 |
---|---|---|
committer | ermolovd <ermolovd@yandex-team.com> | 2024-10-04 11:02:02 +0300 |
commit | 19d4673382658aafc539ebfe03fe7e297a3aa261 (patch) | |
tree | 96d0fa2f77947ec9f27000c440536ea4b974719c | |
parent | 9ad2894d3a432775a19303a5e8b7a79092017963 (diff) | |
download | ydb-19d4673382658aafc539ebfe03fe7e297a3aa261.tar.gz |
YT-22871: Disable option for switching to sync pinger
* Changelog entry
Type: feature
Component: cpp-mapreduce-sdk
Removed old style synchronous pinger
commit_hash:111d1bdf6f21cc2eff949224eea06c219af70051
-rw-r--r-- | yt/cpp/mapreduce/client/transaction_pinger.cpp | 26 | ||||
-rw-r--r-- | yt/cpp/mapreduce/interface/config.cpp | 1 | ||||
-rw-r--r-- | yt/cpp/mapreduce/interface/config.h | 1 |
3 files changed, 11 insertions, 17 deletions
diff --git a/yt/cpp/mapreduce/client/transaction_pinger.cpp b/yt/cpp/mapreduce/client/transaction_pinger.cpp index 3b6ff2efc5..0a193352f7 100644 --- a/yt/cpp/mapreduce/client/transaction_pinger.cpp +++ b/yt/cpp/mapreduce/client/transaction_pinger.cpp @@ -292,21 +292,17 @@ private: ITransactionPingerPtr CreateTransactionPinger(const TConfigPtr& config) { - if (config->UseAsyncTxPinger) { - YT_LOG_DEBUG("Using async transaction pinger"); - auto httpClientConfig = NYT::New<NHttp::TClientConfig>(); - httpClientConfig->MaxIdleConnections = 16; - auto httpPoller = NConcurrency::CreateThreadPoolPoller( - config->AsyncHttpClientThreads, - "tx_http_client_poller"); - auto httpClient = NHttp::CreateClient(std::move(httpClientConfig), std::move(httpPoller)); - - return MakeIntrusive<TSharedTransactionPinger>( - std::move(httpClient), - config->AsyncTxPingerPoolThreads); - } else { - return MakeIntrusive<TThreadPerTransactionPinger>(); - } + YT_LOG_DEBUG("Using async transaction pinger"); + auto httpClientConfig = NYT::New<NHttp::TClientConfig>(); + httpClientConfig->MaxIdleConnections = 16; + auto httpPoller = NConcurrency::CreateThreadPoolPoller( + config->AsyncHttpClientThreads, + "tx_http_client_poller"); + auto httpClient = NHttp::CreateClient(std::move(httpClientConfig), std::move(httpPoller)); + + return MakeIntrusive<TSharedTransactionPinger>( + std::move(httpClient), + config->AsyncTxPingerPoolThreads); } //////////////////////////////////////////////////////////////////////////////// diff --git a/yt/cpp/mapreduce/interface/config.cpp b/yt/cpp/mapreduce/interface/config.cpp index 879bf79561..418868a7eb 100644 --- a/yt/cpp/mapreduce/interface/config.cpp +++ b/yt/cpp/mapreduce/interface/config.cpp @@ -200,7 +200,6 @@ void TConfig::Reset() GlobalTxId = GetEnv("YT_TRANSACTION", ""); - UseAsyncTxPinger = true; AsyncHttpClientThreads = 1; AsyncTxPingerPoolThreads = 1; diff --git a/yt/cpp/mapreduce/interface/config.h b/yt/cpp/mapreduce/interface/config.h index a8baac8d4f..71f0c4fcdc 100644 --- a/yt/cpp/mapreduce/interface/config.h +++ b/yt/cpp/mapreduce/interface/config.h @@ -104,7 +104,6 @@ struct TConfig TDuration PingTimeout; TDuration PingInterval; - bool UseAsyncTxPinger; int AsyncHttpClientThreads; int AsyncTxPingerPoolThreads; |