diff options
| author | Vlad Kuznetsov <va-kuznecov@ydb.tech> | 2024-09-27 15:57:59 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-27 13:57:59 +0000 |
| commit | 08705835d3a9f43513ef2cb0f1d06b0bf4910feb (patch) | |
| tree | 66eff1fc7c13798c497a29766984024dbb15dbda | |
| parent | c0733235b3ab8fdff2a22e2f3dd15993fde4dcfe (diff) | |
| download | ydb-08705835d3a9f43513ef2cb0f1d06b0bf4910feb.tar.gz | |
Fix log priority and refactor switch in ProcessChunkWriteQueue (#9840)
| -rw-r--r-- | ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl.cpp | 33 |
1 files changed, 14 insertions, 19 deletions
diff --git a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl.cpp b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl.cpp index a04b24ff55a..a2b6bead214 100644 --- a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl.cpp +++ b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl.cpp @@ -2222,25 +2222,20 @@ void TPDisk::ProcessChunkWriteQueue() { TRequestBase *req = (*it); req->SpanStack.PopOk(); req->SpanStack.Push(TWilson::PDiskDetailed, "PDisk.InBlockDevice", NWilson::EFlags::AUTO_END); - switch (req->GetType()) { - case ERequestType::RequestChunkWritePiece: - { - TChunkWritePiece *piece = static_cast<TChunkWritePiece*>(req); - P_LOG(PRI_NOTICE, BPD01, "ChunkWritePiece", - (ChunkIdx, piece->ChunkWrite->ChunkIdx), - (Offset, piece->PieceShift), - (Size, piece->PieceSize) - ); - bool lastPart = ChunkWritePiece(piece->ChunkWrite.Get(), piece->PieceShift, piece->PieceSize); - if (lastPart) { - Mon.IncrementQueueTime(piece->ChunkWrite->PriorityClass, piece->ChunkWrite->LifeDurationMs(now)); - } - delete piece; - break; - } - default: - Y_FAIL_S("Unexpected request type# " << ui64(req->GetType()) << " in JointChunkWrites"); + + Y_VERIFY_S(req->GetType() == ERequestType::RequestChunkWritePiece, "Unexpected request type# " << ui64(req->GetType()) + << " TypeName# " << TypeName(*req) << " in JointChunkWrites"); + TChunkWritePiece *piece = static_cast<TChunkWritePiece*>(req); + P_LOG(PRI_DEBUG, BPD01, "ChunkWritePiece", + (ChunkIdx, piece->ChunkWrite->ChunkIdx), + (Offset, piece->PieceShift), + (Size, piece->PieceSize) + ); + bool lastPart = ChunkWritePiece(piece->ChunkWrite.Get(), piece->PieceShift, piece->PieceSize); + if (lastPart) { + Mon.IncrementQueueTime(piece->ChunkWrite->PriorityClass, piece->ChunkWrite->LifeDurationMs(now)); } + delete piece; } LWTRACK(PDiskProcessChunkWriteQueue, UpdateCycleOrbit, PCtx->PDiskId, JointChunkWrites.size()); JointChunkWrites.clear(); @@ -2267,7 +2262,7 @@ void TPDisk::ProcessChunkReadQueue() { ui8 priorityClass = read->PriorityClass; NHPTimer::STime creationTime = read->CreationTime; Y_VERIFY(!read->IsReplied); - P_LOG(PRI_NOTICE, BPD36, "Performing TChunkReadPiece", (ReqId, reqId), (chunkIdx, chunkIdx), + P_LOG(PRI_DEBUG, BPD36, "Performing TChunkReadPiece", (ReqId, reqId), (chunkIdx, chunkIdx), (PieceCurrentSector, piece->PieceCurrentSector), (PieceSizeLimit, piece->PieceSizeLimit), (IsTheLastPiece, piece->IsTheLastPiece), |