aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCthulhu <cthulhu@ydb.tech>2024-07-23 22:52:46 +0300
committerGitHub <noreply@github.com>2024-07-23 22:52:46 +0300
commit054742d5cfc69ef0d95d89f0409cea6f18eab96b (patch)
tree109ee1c031cd9458bb1cf45997b061de9b1a86f1
parent582cd7b5928beac8f403e84b9ef63b1c4680b470 (diff)
downloadydb-054742d5cfc69ef0d95d89f0409cea6f18eab96b.tar.gz
Fix LWTrace leaking HTTP request string to HTML page (#7011) (#7014)
-rw-r--r--library/cpp/lwtrace/mon/mon_lwtrace.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/library/cpp/lwtrace/mon/mon_lwtrace.cpp b/library/cpp/lwtrace/mon/mon_lwtrace.cpp
index 09d56560c4..a10ae4a775 100644
--- a/library/cpp/lwtrace/mon/mon_lwtrace.cpp
+++ b/library/cpp/lwtrace/mon/mon_lwtrace.cpp
@@ -301,7 +301,7 @@ public:
}
} catch (...) {
ythrow yexception()
- << CurrentExceptionMessage()
+ << EncodeHtmlPcdata(CurrentExceptionMessage())
<< " while parsing track log query: "
<< Text;
}
@@ -1853,7 +1853,7 @@ public:
try {
Os << src->GetStartTime().ToStringUpToSeconds();
} catch (...) {
- Os << "error: " << CurrentExceptionMessage();
+ Os << "error: " << EncodeHtmlPcdata(CurrentExceptionMessage());
}
Os << "</td>"
<< "<td><div class=\"dropdown\">"
@@ -3821,17 +3821,17 @@ public:
}
} catch (TPageGenBase& gen) {
out.Clear();
- out << gen.what();
+ out << EncodeHtmlPcdata(gen.what());
} catch (...) {
out.Clear();
if (request.GetParams().Get("error") == "text") {
// Text error reply is helpful for ajax requests
out << NMonitoring::HTTPOKTEXT;
- out << CurrentExceptionMessage();
+ out << EncodeHtmlPcdata(CurrentExceptionMessage());
} else {
WWW_HTML(out) {
out << "<h2>Error</h2><pre>"
- << CurrentExceptionMessage()
+ << EncodeHtmlPcdata(CurrentExceptionMessage())
<< Endl;
}
}