Disable by default RENAME for column table (#21078)

7 files changed, 25 insertions, 3 deletions

diff --git a/ydb/core/kqp/ut/federated_query/common/common.cpp b/ydb/core/kqp/ut/federated_query/common/common.cpp
index f94f0b602b7..8921eef1e9d 100644
--- a/ydb/core/kqp/ut/federated_query/common/common.cpp
+++ b/ydb/core/kqp/ut/federated_query/common/common.cpp
@@ -61,6 +61,7 @@ namespace NKikimr::NKqp::NFederatedQueryTest {
         featureFlags.SetEnableExternalDataSources(true);
         featureFlags.SetEnableScriptExecutionOperations(true);
         featureFlags.SetEnableExternalSourceSchemaInference(true);
+        featureFlags.SetEnableMoveColumnTable(true);
         if (!appConfig) {
             appConfig.emplace();
             appConfig->MutableQueryServiceConfig()->SetAllExternalDataSourcesAreAvailable(true);
diff --git a/ydb/core/kqp/ut/query/kqp_query_ut.cpp b/ydb/core/kqp/ut/query/kqp_query_ut.cpp
index 22551c21f07..43bb4c5fd17 100644
--- a/ydb/core/kqp/ut/query/kqp_query_ut.cpp
+++ b/ydb/core/kqp/ut/query/kqp_query_ut.cpp
@@ -1490,8 +1490,11 @@ Y_UNIT_TEST_SUITE(KqpQuery) {
         appConfig.MutableTableServiceConfig()->SetEnableOlapSink(true);
         appConfig.MutableTableServiceConfig()->SetEnableCreateTableAs(true);
         appConfig.MutableTableServiceConfig()->SetEnablePerStatementQueryExecution(true);
+        NKikimrConfig::TFeatureFlags featureFlags;
+        featureFlags.SetEnableMoveColumnTable(true);
         auto settings = TKikimrSettings()
             .SetAppConfig(appConfig)
+            .SetFeatureFlags(featureFlags)
             .SetWithSampleTables(false);
         TKikimrRunner kikimr(settings);
 
@@ -1770,8 +1773,11 @@ Y_UNIT_TEST_SUITE(KqpQuery) {
         appConfig.MutableTableServiceConfig()->SetEnableOlapSink(true);
         appConfig.MutableTableServiceConfig()->SetEnableCreateTableAs(true);
         appConfig.MutableTableServiceConfig()->SetEnablePerStatementQueryExecution(true);
+        NKikimrConfig::TFeatureFlags featureFlags;
+        featureFlags.SetEnableMoveColumnTable(true);
         auto settings = TKikimrSettings()
             .SetAppConfig(appConfig)
+            .SetFeatureFlags(featureFlags)
             .SetWithSampleTables(false)
             .SetEnableTempTables(true);
         TKikimrRunner kikimr(settings);
@@ -1945,8 +1951,11 @@ Y_UNIT_TEST_SUITE(KqpQuery) {
         appConfig.MutableTableServiceConfig()->SetEnableOltpSink(false);
         appConfig.MutableTableServiceConfig()->SetEnableHtapTx(false);
         appConfig.MutableTableServiceConfig()->SetEnableCreateTableAs(true);
+        NKikimrConfig::TFeatureFlags featureFlags;
+        featureFlags.SetEnableMoveColumnTable(true);
         auto settings = TKikimrSettings()
             .SetAppConfig(appConfig)
+            .SetFeatureFlags(featureFlags)
             .SetWithSampleTables(false)
             .SetEnableTempTables(true);
         TKikimrRunner kikimr(settings);
@@ -2328,8 +2337,11 @@ Y_UNIT_TEST_SUITE(KqpQuery) {
         appConfig.MutableTableServiceConfig()->SetEnableOltpSink(true);
         appConfig.MutableTableServiceConfig()->SetEnableCreateTableAs(true);
         appConfig.MutableTableServiceConfig()->SetEnablePerStatementQueryExecution(true);
+        NKikimrConfig::TFeatureFlags featureFlags;
+        featureFlags.SetEnableMoveColumnTable(true);
         auto settings = TKikimrSettings()
             .SetAppConfig(appConfig)
+            .SetFeatureFlags(featureFlags)
             .SetWithSampleTables(false)
             .SetEnableTempTables(true);
         TKikimrRunner kikimr(settings);
diff --git a/ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp b/ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp
index 2c8f147de94..468b9674b3f 100644
--- a/ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp
+++ b/ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp
@@ -1160,7 +1160,9 @@ Y_UNIT_TEST_SUITE(KqpScheme) {
     }
 
     Y_UNIT_TEST_TWIN(RenameTable, СolumnTable) {
-        TKikimrRunner kikimr;
+        NKikimrConfig::TFeatureFlags featureFlags;
+        featureFlags.SetEnableMoveColumnTable(true);
+        TKikimrRunner kikimr(featureFlags);
         auto db = kikimr.GetTableClient();
         auto session = db.CreateSession().GetValueSync().GetSession();
 
diff --git a/ydb/core/protos/feature_flags.proto b/ydb/core/protos/feature_flags.proto
index 8ec579920b1..b7982895ab9 100644
--- a/ydb/core/protos/feature_flags.proto
+++ b/ydb/core/protos/feature_flags.proto
@@ -216,5 +216,5 @@ message TFeatureFlags {
     optional bool EnableSystemNamesProtection = 190 [default = false];
     optional bool EnableRealSystemViewPaths = 191 [default = false, (RequireRestart) = true];
     optional bool EnableCSSchemasCollapsing = 192 [default = true];
-    optional bool EnableMoveColumnTable = 193 [default = true];
+    optional bool EnableMoveColumnTable = 193 [default = false];
 }
diff --git a/ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp b/ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp
index 4f0f04434b9..aa97ab3dfe2 100644
--- a/ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp
+++ b/ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp
@@ -1200,6 +1200,7 @@ Y_UNIT_TEST_SUITE(TOlap) {
     Y_UNIT_TEST(MoveTableStats) {
         TTestBasicRuntime runtime;
         TTestEnv env(runtime);
+        runtime.GetAppData().FeatureFlags.SetEnableMoveColumnTable(true);
 
         auto csController = NYDBTest::TControllers::RegisterCSControllerGuard<NYDBTest::NColumnShard::TController>();
         csController->SetOverridePeriodicWakeupActivationPeriod(TDuration::Seconds(1));
diff --git a/ydb/tests/fq/yt/kqp_yt_import/kqprun_import_config.conf b/ydb/tests/fq/yt/kqp_yt_import/kqprun_import_config.conf
index c4e4433fa6a..ccbcb7dec5e 100644
--- a/ydb/tests/fq/yt/kqp_yt_import/kqprun_import_config.conf
+++ b/ydb/tests/fq/yt/kqp_yt_import/kqprun_import_config.conf
@@ -6,6 +6,7 @@ FeatureFlags {
   EnableExternalDataSources: true
   EnableScriptExecutionOperations: true
   EnablePgSyntax: true
+  EnableMoveColumnTable: true
 }
 
 QueryServiceConfig {
diff --git a/ydb/tests/olap/s3_import/base.py b/ydb/tests/olap/s3_import/base.py
index e598a29b2a2..0452c5479c3 100644
--- a/ydb/tests/olap/s3_import/base.py
+++ b/ydb/tests/olap/s3_import/base.py
@@ -26,7 +26,12 @@ class S3ImportTestBase(object):
     @classmethod
     def _get_ydb_config(cls):
         config = KikimrConfigGenerator(
-            extra_feature_flags={"enable_external_data_sources": True}
+            extra_feature_flags={
+                "enable_external_data_sources": True,
+                "enable_move_column_table": True
+            },
+            query_service_config={"available_external_data_sources": ["ObjectStorage"]},
+            table_service_config={}
         )
         config.yaml_config["query_service_config"] = {}
         config.yaml_config["query_service_config"]["available_external_data_sources"] = ["ObjectStorage"]