aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec/vvc
Commit message (Collapse)AuthorAgeFilesLines
* avcodec/vvc/dec: fix typo and also output log when the checksum is correctWu Jianhua4 days1-7/+5
| | | | | | It's helpful for developers and the same as the hevcdec. Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/ctu: should use the width and height of the start componentWu Jianhua4 days1-11/+18
| | | | | | This commit fixed decoding the DUAL_TREE_CHROMA palette coding unit Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/ctu: check coeff before multiplyKacper Michajłow5 days1-1/+1
| | | | | | | | | | | ff_vvc_palette_escape_val() can return AVERROR in which case the coeff*scale will overflow. Fixes: runtime error: signed integer overflow: -1094995529 * 6528 cannot be represented in type 'int' Fixes: 435225406/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-5118570024730624 Found-by: OSS-Fuzz Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
* all: fix typos found by codespellTimo Rothenpieler9 days2-2/+2
|
* all: fix whitespace/new-line issuesTimo Rothenpieler9 days1-1/+0
|
* lavc/vvc: Mark SPS used if multiple CLVSSs use itFrank Plowman10 days1-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | Consider the following sequence of NALUs (with some PPSs etc. omitted for brevity): 1. SPS (ID=0, content=A) 2. IDR (SPS=0) 3. IDR (SPS=0) 4. SPS (ID=0, content=B) 5. TRAIL (SPS=0) When decode_sps is called for NALU 3., ps->sps_id_used is cleared as IDRs are one way of forming a CLVSS. Then, old_sps is non-NULL containing the result of calling decode_sps for NALU 2. We haven't received any SPSs between NALUs 2. and 3., therefore old_sps and rsps are identical and the function returns. The issue is that, at this point, ps->sps_id_used is still zero despite the SPS being used for IDR 3. This results in the check for conflicting SPSs not working properly when decode_sps is called for NALU 5., allowing prediction between pictures with different SPSs and probably all sorts of other shenanigans. Patch addresses the problem outlined above by also setting ps->sps_id_used in the early return case.
* lavc/vvc: Add max parameter to kth_order_egk_decodeFrank Plowman2025-07-283-19/+25
| | | | | | | | | | | | | | | Prior to this patch, kth_order_egk_decode could read arbitrarily large values which then overflowed and caused various issues. Patch fixes this by making kth_order_egk_decode falliable, requiring the caller to specify an upper bound and returning an error if the read value would exceed that bound. This patch resolves the same issue as eb52251c0ab025b6b40b28994bc9dc616813b190, but I think this is the proper fix as it also addresses issues with syntax elements besides ff_vvc_num_signalled_palette_entries. Signed-off-by: Frank Plowman <post@frankplowman.com>
* lavc/vvc: Don't discard palette_subblock_data return codeFrank Plowman2025-07-281-2/+5
| | | | Signed-off-by: Frank Plowman <post@frankplowman.com>
* avcodec/vvc/dec: Don't use GetBit-API when byte-alignedAndreas Rheinhardt2025-07-111-13/+16
| | | | Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avcodec/vvc/ctu: Check ff_vvc_num_signalled_palette_entriesMichael Niedermayer2025-07-061-1/+1
| | | | | | | | Fixes: index 107 out of bounds for type 'uint16_t const[63]' Fixes: 421336912/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-6436225806565376 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avcodec/vvc/ctu: Check palette_escape_valMichael Niedermayer2025-07-061-0/+2
| | | | | | | | Fixes: integer overflow Fixes: 418314174/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4871731867353088 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avcodec/vvc/refs: remove early returnMarvin Scholz2025-06-281-3/+2
| | | | | | | | | | | | | The ret value is checked later on again, so this check is redundant and would cause the frame to not be unrefd on failure as well. So remove this check and add one before av_frame_remove_side_data to ensure it is not called with an invalid frame. Fix CID 1648350 Reviewed-by: Frank Plowman <post@frankplowman.com>
* lavc/vvc: Fix condition for using default scaling factorFrank Plowman2025-06-271-3/+3
| | | | | | | | | | | Add handling here for sps_scaling_matrix_for_alternative_colour_space_disabled_flag. Also add parentheses to make behaviour a little more explicit, where &&'s precedence over || was relied on previously. Reported-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Frank Plowman <post@frankplowman.com>
* avcodec/vvc: parse all SEI messagesMarvin Scholz2025-06-121-7/+22
| | | | | | | | | While the current code iterated over the messages, it always returned in the first iteration. Instead keep iterating and warn for failure to parse. At time of writing, none of the parsing functions seems to actually return an error, ever. Fix CID 1648348
* avcodec/vvc/dec: fix possible null-pointer dereferenceMarvin Scholz2025-06-121-1/+2
| | | | | | | | | When checking for filmgrain here, needs_fg can be true even when film_grain_characteristics is NULL (when aom_film_grain.enable is true), therefore this check could end up dereferencing film_grain_characteristics even though it is NULL. Fix CID 1648347
* lavc/vvc: Fix unchecked return code and shadowingFrank Plowman2025-06-071-2/+6
| | | | Signed-off-by: Frank Plowman <post@frankplowman.com>
* avcodec/vvc/sei: add decode_mastering_display_colour_volumeWu Jianhua2025-05-311-0/+21
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/sei: add decode_ambient_viewing_environmentWu Jianhua2025-05-311-0/+13
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc: support fieldsWu Jianhua2025-05-311-0/+8
| | | | | | | | passed files: FIELD_A_Panasonic_4.bit FIELD_B_Panasonic_2.bit Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/sei: add decode_frame_field_infoWu Jianhua2025-05-312-0/+27
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/sei: add decode_content_light_level_infoWu Jianhua2025-05-311-0/+12
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/sei: add decode_display_orientationWu Jianhua2025-05-311-0/+27
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvcdec: verify picture hashWu Jianhua2025-05-312-1/+22
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/sei: add decode_decoded_picture_hashWu Jianhua2025-05-312-0/+21
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/dec: support removing film grain params from side dataWu Jianhua2025-05-311-0/+3
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/dec: support applying film grain by the decoderWu Jianhua2025-05-313-5/+103
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/dec: export sei to the frame when the frame startsWu Jianhua2025-05-311-0/+12
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/sei: add decode_film_grain_characteristicsWu Jianhua2025-05-311-0/+66
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc: support decoding prefix and suffix nal unitsWu Jianhua2025-05-315-0/+135
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* lavc/vvc: Fix divide-by-zero in LMCS param derivationFrank Plowman2025-05-251-3/+14
| | | | | | | Add three missing requirements on bitstream conformance from 7.4.3.19 of H.266 (V3). Issue found using fuzzing. Signed-off-by: Frank Plowman <post@frankplowman.com>
* lavc/vvc: Avoid UB in DB strength derivation for PLT CUsFrank Plowman2025-05-241-0/+3
| | | | | | | | | | When called for palette-predicted CUs, boundary_strength could cause undefined behaviour due to accessing uninitialised motion information. The spec doesn't include this, but in the reference software it seems the deblock strength is always set to 0 for palette CUs due to some implementation details: perhaps this is a spec issue? Signed-off-by: Frank Plowman <post@frankplowman.com>
* lavc/vvc: Detect subpic overlaps at CTU levelFrank Plowman2025-05-241-47/+57
| | | | | | | | | | | | | In d5dbcc00d889fb17948b025a468b00ddbea9e058, it was hoped that detection of subpicture overlaps could be performed at the tile level, so as to avoid introducing per-CTU checks. Unfortunately since that patch, fuzzing has indicated there are some structures involving pps_subpic_one_or_more_tiles_slice where tile-level checking is not sufficient. Performing the check at the CTU level should (touch wood) be the be-all and and-all of this, as CTUs are the lowest common denominator of the picture partitioning. Signed-off-by: Frank Plowman <post@frankplowman.com>
* lavc/vvc/plt: validate run and signalled_entriesNuo Mi2025-05-241-5/+23
| | | | | | | | Fixes a crash triggered by a fuzzed clip: https://github.com/ffvvc/tests/tree/main/fuzz/passed/000256.bit Reproduce with: ffmpeg -i 000256.bit -f null -
* avcodec/vvc: add adaptive color transform supportWu Jianhua2025-05-172-2/+13
| | | | | | | | passed files: ACT_A_Kwai_3.bit ACT_B_Kwai_3.bit Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/intra: refact out lmcs_scale_chroma and add_residualWu Jianhua2025-05-171-44/+63
| | | | | | prepare for adaptive color transform Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/intra: make lmcs_scale_chroma inplaceWu Jianhua2025-05-173-8/+6
| | | | | | prepare for adaptive color transform Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/intra: refact, predict jcbcr to tb->coeffsWu Jianhua2025-05-173-50/+20
| | | | | | prepare for adaptive color transform Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/intra: fix scaling process for transform coefficientsWu Jianhua2025-05-171-14/+8
| | | | | | See 8.7.3 Scaling process for transform coefficients Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/dsp: add adaptive_color_transformWu Jianhua2025-05-172-0/+22
| | | | | | See 8.7.4.6 Residual modification process for blocks using colour space conversion Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/dsp: update the interface of pred_residual_joint for joint cbcr ↵Wu Jianhua2025-05-173-9/+6
| | | | | | residual functionality Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/ctu: fix derive_chroma_intra_pred_modeWu Jianhua2025-05-171-27/+30
| | | | | | See 8.4.3 Derivation process for chroma intra prediction mode Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/ctu: read act_enabled_flag for adaptive color transformWu Jianhua2025-05-171-8/+5
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/cabac: add ff_vvc_cu_act_enabled_flagWu Jianhua2025-05-172-0/+6
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/intra: add palette coding decoderWu Jianhua2025-05-171-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | Introduction at https://ieeexplore.ieee.org/document/9408666 passed files: 10b422_G_Sony_5.bit 10b422_H_Sony_5.bit 10b422_I_Sony_5.bit 10b422_J_Sony_5.bit 10b422_K_Sony_5.bit 10b422_L_Sony_5.bit 8b422_G_Sony_5.bit 8b422_H_Sony_5.bit 8b422_I_Sony_5.bit 8b422_J_Sony_5.bit 8b422_K_Sony_5.bit 8b422_L_Sony_5.bit 8b444_A_Kwai_2.bit 8b444_B_Kwai_2.bit PALETTE_A_Alibaba_2.bit PALETTE_B_Alibaba_2.bit PALETTE_C_Alibaba_2.bit PALETTE_D_Alibaba_2.bit PALETTE_E_Alibaba_2.bit Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/filter: skip deblocking filter for paletteWu Jianhua2025-05-171-11/+18
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/ctu: add palette supportWu Jianhua2025-05-175-30/+327
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/intra: add ff_vvc_palette_derive_scaleWu Jianhua2025-05-172-20/+33
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc/ctu: refact out intra_dataWu Jianhua2025-05-171-24/+40
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc: refact, save pf and ciip_flag in ff_vvc_set_intra_mvfWu Jianhua2025-05-173-7/+23
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
* avcodec/vvc: refact out ep_init and ep_init_wppWu Jianhua2025-05-172-21/+39
| | | | Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
generated by cgit v1.2.3 (git 2.25.1) at 2025-08-12 05:17:33 +0000