diff options
| author | Janne Grunau <janne-libav@jannau.net> | 2016-11-18 21:06:40 +0100 |
|---|---|---|
| committer | Janne Grunau <janne-libav@jannau.net> | 2016-11-24 21:26:22 +0100 |
| commit | 6a1ea4ec932f4fc9fdc00ec51ee070b298ddb35f (patch) | |
| tree | be6da974e66ab6ddd7081dde7fba65adfcb66c84 /libavutil/arm | |
| parent | 5bcc6f76f180d0f88269018727c92fc562fb8abb (diff) | |
| download | ffmpeg-6a1ea4ec932f4fc9fdc00ec51ee070b298ddb35f.tar.gz | |
arm: warn/error on movrelx usage problematic with PIC on ELF
The warning has false positives but our asm does not trigger it. For
new code false positives can only be avoided by changing the register
allocation.
Diffstat (limited to 'libavutil/arm')
| -rw-r--r-- | libavutil/arm/asm.S | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/libavutil/arm/asm.S b/libavutil/arm/asm.S index 4ac0ea2e4f..a791e80c57 100644 --- a/libavutil/arm/asm.S +++ b/libavutil/arm/asm.S @@ -184,6 +184,15 @@ T ldr \rd, [\rd] .endm .macro movrelx rd, val, gp + .ifc \rd,\gp + .error "movrelx needs two distinct registers" + .endif + .ifc \rd\()_\gp,r12_ + .warning "movrelx rd=\rd without explicit set gp" + .endif + .ifc \rd\()_\gp,ip_ + .warning "movrelx rd=\rd without explicit set gp" + .endif #if CONFIG_PIC && defined(__ELF__) .ifnb \gp .if .Lpic_gp |