aboutsummaryrefslogtreecommitdiffstats
path: root/libavformat
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-01-26 11:27:36 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2020-01-26 17:24:41 +0100
commitf1d46db92625b62c82414b667a3203dd16d491e5 (patch)
tree763409f77e593aae181be4288d5fd474eb7551a5 /libavformat
parent556c4e38d57f467a7f9367d8edda0d48ec6f585e (diff)
downloadffmpeg-f1d46db92625b62c82414b667a3203dd16d491e5.tar.gz
avformat/audiointerleave: Check before dereferencing
In order to use ff_audio_rechunk_interleave() (a special interleavement function for situations where the ordinary "interleave by dts" is not appropriate), the AVStreams must have private data and this private data must begin with an AudioInterleaveContext which contains a fifo that may need to be freed and when ff_audio_interleave_close() was called, it just assumed that everything has been properly set up, i.e. that every streams priv_data exists. This implies that this function can not be called from the deinit function of a muxer, because such functions might be called if the private data has not been successfully allocated. In order to change this, add a check for whether the private data exists before trying to free the fifo in it. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavformat')
-rw-r--r--libavformat/audiointerleave.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/audiointerleave.c b/libavformat/audiointerleave.c
index b602eb7105..6797546a44 100644
--- a/libavformat/audiointerleave.c
+++ b/libavformat/audiointerleave.c
@@ -33,7 +33,7 @@ void ff_audio_interleave_close(AVFormatContext *s)
AVStream *st = s->streams[i];
AudioInterleaveContext *aic = st->priv_data;
- if (st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO)
+ if (aic && st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO)
av_fifo_freep(&aic->fifo);
}
}