diff options
author | Leandro Santiago <leandrosansilva@gmail.com> | 2024-10-31 21:48:27 +0100 |
---|---|---|
committer | Marton Balint <cus@passwd.hu> | 2024-11-19 23:50:49 +0100 |
commit | 69cbda5770d2fb0d7f11de3a7ba0fea16c6b65b4 (patch) | |
tree | 173a23bcc3b2bf440460e30e7c1e84c39b08d1fa /libavformat/vivo.c | |
parent | 9d8f7bf4b836aea86525997953d313b6c96217f3 (diff) | |
download | ffmpeg-69cbda5770d2fb0d7f11de3a7ba0fea16c6b65b4.tar.gz |
lavfi/vf_drawtext: fix memory management when destroying font face
Ref https://trac.ffmpeg.org/ticket/11152
According to harfbuzz docs, hb_ft_font_set_funcs() does not need to be
called, as, quoted:
```
An #hb_font_t object created with hb_ft_font_create()
is preconfigured for FreeType font functions and does not
require this function to be used.
```
Using this function seems to cause memory management issues between
harfbuzz and freetype, and could be eliminated.
This commit also call hb_ft_font_changed() when the underlying FC_Face
changes size, as stated on hardbuzz:
```
HarfBuzz also provides a utility function called hb_ft_font_changed() that you should call
whenever you have altered the properties of your underlying FT_Face, as well as a hb_ft_get_face()
that you can call on an hb_font_t font object to fetch its underlying FT_Face.
```
Finally, the execution order between hb_font_destroy() and
hb_buffer_destroy() is flipped to match the order of creation of
the respective objects.
Signed-off-by: Leandro Santiago <leandrosansilva@gmail.com>
Signed-off-by: Marton Balint <cus@passwd.hu>
Diffstat (limited to 'libavformat/vivo.c')
0 files changed, 0 insertions, 0 deletions