diff options
author | Derek Buitenhuis <derek.buitenhuis@gmail.com> | 2022-09-22 14:11:31 +0100 |
---|---|---|
committer | Derek Buitenhuis <derek.buitenhuis@gmail.com> | 2022-09-27 17:37:21 +0100 |
commit | f5cd00bf5265cb1d10de925c4d0b3ebb191f0d74 (patch) | |
tree | 9b13c9de46d42f2ac5660109b3e7a6f9ff845ac6 /libavformat/tee_common.c | |
parent | c03f9654c997b33b8028eb71c9e7ba61fd53a813 (diff) | |
download | ffmpeg-f5cd00bf5265cb1d10de925c4d0b3ebb191f0d74.tar.gz |
ffprobe: Check for invalid matrix error when printing rotation
av_display_rotation_get will return NAN when the display matrix is invalid,
which would end up printing NAN as an integer in the rotation field. This
is poor for multiple reasons:
* Users of ffprobe have no way of discerning "valid but ugly rotation from
display matrix" from "invalid display matrix".
* It can have unintended consequences on some platforms, such as Linux x86_64,
where NAN is equal to INT64_MIN, which, for example, when printed as JSON,
which uses floating point for all numbers, can end up as invalid JSON or wit
a number that cannot be reserialized as an integer at all.
Since NAN is av_display_rotation_get's error case, just print 0 (no rotation)
when that happens.
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Diffstat (limited to 'libavformat/tee_common.c')
0 files changed, 0 insertions, 0 deletions