aboutsummaryrefslogtreecommitdiffstats
path: root/libavformat/mux.c
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-03-12 18:54:07 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2020-03-14 18:24:04 +0100
commit5c5ab88967f0f00c5586a1fbf344aeb1166234f0 (patch)
treeebdfc64014e1215b500644f566c156e693a19809 /libavformat/mux.c
parentcc2a9509ce79793fcd00f91bb6ca3f4c53721e9e (diff)
downloadffmpeg-5c5ab88967f0f00c5586a1fbf344aeb1166234f0.tar.gz
avformat/mux: Remove redundant checks for write errors
If writing a packet didn't directly return an error, the AVIOContext's error flag is checked for errors (if existing) by write_packet(). And if write_packet() didn't indicate an error, its callers checked the error flag of the AVIOContext (if existing). The latter check is redundant. The reason for checking twice lies in the FFmpeg-Libav split: The check in write_packet() has been added in 9ad1e0c1 in Libav. FFmpeg already had the other checks (since aec9390a), but when 9ad1e0c1 was merged (in 1f1c1008), no one noticed the redundant checks. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavformat/mux.c')
-rw-r--r--libavformat/mux.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/libavformat/mux.c b/libavformat/mux.c
index d88746e8c5..bc2eab0c96 100644
--- a/libavformat/mux.c
+++ b/libavformat/mux.c
@@ -913,8 +913,6 @@ int av_write_frame(AVFormatContext *s, AVPacket *pkt)
#endif
ret = write_packet(s, pkt);
- if (ret >= 0 && s->pb && s->pb->error < 0)
- ret = s->pb->error;
if (ret >= 0)
s->streams[pkt->stream_index]->nb_frames++;
@@ -1246,8 +1244,6 @@ int av_interleaved_write_frame(AVFormatContext *s, AVPacket *pkt)
if (ret < 0)
return ret;
- if(s->pb && s->pb->error)
- return s->pb->error;
}
fail:
av_packet_unref(pkt);
@@ -1274,8 +1270,6 @@ int av_write_trailer(AVFormatContext *s)
if (ret < 0)
goto fail;
- if(s->pb && s->pb->error)
- goto fail;
}
fail: