diff options
author | Mattias Wadman <mattias.wadman@gmail.com> | 2020-05-19 11:27:11 +0200 |
---|---|---|
committer | Anton Khirnov <anton@khirnov.net> | 2020-05-25 11:59:45 +0200 |
commit | af97c9865fe7a48b223e162eabce21cc180f305c (patch) | |
tree | 17ec297bee328b5eefd87f34783e185f57fa569f /libavformat/mmsh.c | |
parent | ea980d4162cf783c3ed9978c6e12b9908f5b039b (diff) | |
download | ffmpeg-af97c9865fe7a48b223e162eabce21cc180f305c.tar.gz |
libavformat/flacdec: Workaround for truncated metadata picture size
Some flac muxers write truncated metadata picture size if the picture
data do not fit in 24 bits. Detect this by truncting the size found inside
the picture block and if it matches the block size use it and read rest
of picture data.
This workaround is only for flac files and not ogg files with flac
METADATA_BLOCK_PICTURE comments and it can be disabled with strict level
above normal. Currently there is a 500MB limit on truncate size to protect
from large memory allocations.
The truncation bug in lavf flacenc was fixed in e447a4d112bcfee10126c54eb4481fa8712957c8
but based on existing broken files other unknown flac muxers seems to truncate also.
Before the fix a broken flac file for reproduction could be generated with:
ffmpeg -f lavfi -i sine -f lavfi -i color=red:size=2400x2400 -map 0:0 -map 1:0 -c:v:0 bmp -disposition:1 attached_pic -t 1 test.flac
Fixes ticket 6333
Signed-off-by: Anton Khirnov <anton@khirnov.net>
Diffstat (limited to 'libavformat/mmsh.c')
0 files changed, 0 insertions, 0 deletions