aboutsummaryrefslogtreecommitdiffstats
path: root/libavformat/mm.c
diff options
context:
space:
mode:
authorwm4 <nfxjfg@googlemail.com>2014-11-14 13:34:50 +0100
committerAnton Khirnov <anton@khirnov.net>2014-11-27 13:38:29 +0100
commit517ce1d09b5e6b72afc2ef9490b5f8ca42fa6a65 (patch)
tree7470f5de9856498fdfaaf4b350956284a9c46fc5 /libavformat/mm.c
parent46a17d886b8559723c40b9f5cdf0e0c6b1c95180 (diff)
downloadffmpeg-517ce1d09b5e6b72afc2ef9490b5f8ca42fa6a65.tar.gz
lavu: fix memory leaks by using a mutex instead of atomics
The buffer pool has to atomically add and remove entries from the linked list of available buffers. This was done by removing the entire list with a CAS operation, working on it, and then setting it back again (using a retry-loop in case another thread was doing the same thing). This could effectively cause memory leaks: while a thread was working on the buffer list, other threads would allocate new buffers, increasing the pool's total size. There was no real leak, but since these extra buffers were not needed, but not free'd either (except when the buffer pool was destroyed), this had the same effects as a real leak. For some reason, growth was exponential, and could easily kill the process due to OOM in real-world uses. Fix this by using a mutex to protect the list operations. The fancy way atomics remove the whole list to work on it is not needed anymore, which also avoids the situation which was causing the leak. Signed-off-by: Anton Khirnov <anton@khirnov.net> (cherry picked from commit fbd6c97f9ca858140df16dd07200ea0d4bdc1a83) Signed-off-by: Anton Khirnov <anton@khirnov.net>
Diffstat (limited to 'libavformat/mm.c')
0 files changed, 0 insertions, 0 deletions