diff options
author | Andreas Rheinhardt <andreas.rheinhardt@gmail.com> | 2020-04-14 04:30:59 +0200 |
---|---|---|
committer | Andreas Rheinhardt <andreas.rheinhardt@gmail.com> | 2020-05-20 02:03:53 +0200 |
commit | f60a1e8d34061ee2e692bb5d5d69d4b71a216aa4 (patch) | |
tree | dc19d7dab7ae84a251f387561daa5b9627c09b5a /libavformat/dashenc.c | |
parent | df88108c973d3844a1ae95d3bf8064f59926bc09 (diff) | |
download | ffmpeg-f60a1e8d34061ee2e692bb5d5d69d4b71a216aa4.tar.gz |
avformat/oggenc: Don't free AVStream's priv_data, fix memleak
For FLAC, Speex, Opus and VP8 the Ogg muxer allocates two buffers
for building the headers: The first for extradata in an Ogg-specific
format and the second contains a Vorbiscomment. These buffers are
reachable via pointers in the corresponding AVStream's priv_data.
If an error happens during building the headers, the AVStream's
priv_data would be freed. This is pointless in general as it would be
freed generically anyway, but here it is actively harmful: If the second
of the aforementioned allocations fails, the first buffer would leak
upon freeing priv_data.
This commit stops freeing priv_data manually, which allows the muxer to
properly clean up in the deinit function.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
(cherry picked from commit 0fcf74f4357e949f5971d39b04a128103b8949bb)
Diffstat (limited to 'libavformat/dashenc.c')
0 files changed, 0 insertions, 0 deletions