diff options
author | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2021-09-13 16:54:58 +0200 |
---|---|---|
committer | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2021-09-19 04:44:27 +0200 |
commit | 0c34cf899dc67febb57f5da4ec50640985e4f670 (patch) | |
tree | db7856e20717e8b4ffd65f91ff9da97dcecaaf45 /libavfilter/vf_weave.c | |
parent | 6c8f96f18b92ec312e645e4b32ae6f5010824986 (diff) | |
download | ffmpeg-0c34cf899dc67febb57f5da4ec50640985e4f670.tar.gz |
avfilter/af_aresample: Use preinit instead of init_dict
By using preinit, the SwrContext already exists directly after
allocating the filter, so that the filter's AVClass's child_next
becomes usable for setting options with the AV_OPT_SEARCH_CHILDREN
search flag. This means that it is no longer necessary to use
the init_dict callback for this filter.
Furthermore, the earlier code did not abide by the documentation
of the init_dict callback at all: Instead of only returning the
options that have not been recognized it always returned all options
on any av_opt_set() error and errored out in this case; yet if
the error was just caused by an unrecognized option, it should not
error out at all and instead return said option.
This behaviour has been inherited by avfilter_init_dict(),
contradicting its documentation. This is also fixed by this commit.
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavfilter/vf_weave.c')
0 files changed, 0 insertions, 0 deletions