diff options
author | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2023-08-03 14:37:51 +0200 |
---|---|---|
committer | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2023-08-07 09:21:13 +0200 |
commit | 2f62a433f26cab5d26d59b961b34637c26cf8e22 (patch) | |
tree | 0d70e36850612c6ffe9f55523152aea0b18365ea /libavfilter/vf_noise.c | |
parent | 6d15643173263c8ff9e9422bbbdcb843f4bc8f9c (diff) | |
download | ffmpeg-2f62a433f26cab5d26d59b961b34637c26cf8e22.tar.gz |
avfilter: Deduplicate default video inputs/outputs
Lots of video filters use a very simple input or output:
An array with a single AVFilterPad whose name is "default"
and whose type is AVMEDIA_TYPE_VIDEO; everything else is unset.
Given that we never use pointer equality for inputs or outputs*,
we can simply use a single AVFilterPad instead of dozens; this
even saves .data.rel.ro (8312B here) as well as relocations.
*: In fact, several filters (like the filters in vf_lut.c)
already use the same outputs; furthermore, ff_filter_alloc()
duplicates the input and output pads so that we do not even
work with the pads directly.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavfilter/vf_noise.c')
-rw-r--r-- | libavfilter/vf_noise.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/libavfilter/vf_noise.c b/libavfilter/vf_noise.c index 8ed12f7409..ba843eed4e 100644 --- a/libavfilter/vf_noise.c +++ b/libavfilter/vf_noise.c @@ -330,13 +330,6 @@ static const AVFilterPad noise_inputs[] = { }, }; -static const AVFilterPad noise_outputs[] = { - { - .name = "default", - .type = AVMEDIA_TYPE_VIDEO, - }, -}; - const AVFilter ff_vf_noise = { .name = "noise", .description = NULL_IF_CONFIG_SMALL("Add noise."), @@ -344,7 +337,7 @@ const AVFilter ff_vf_noise = { .init = init, .uninit = uninit, FILTER_INPUTS(noise_inputs), - FILTER_OUTPUTS(noise_outputs), + FILTER_OUTPUTS(ff_video_default_filterpad), FILTER_QUERY_FUNC(query_formats), .priv_class = &noise_class, .flags = AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC | AVFILTER_FLAG_SLICE_THREADS, |