diff options
| author | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2023-08-03 00:59:02 +0200 |
|---|---|---|
| committer | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2023-08-07 09:21:13 +0200 |
| commit | 50ea7389ecae321ea6c4c585b8f721b84bd64a1d (patch) | |
| tree | 87f92b2b059f2ca17392f5dceca05c14d1859934 /libavfilter/avf_showwaves.c | |
| parent | 6b82f35041fd3229f056e9b8644e8a91d0e0bc19 (diff) | |
| download | ffmpeg-50ea7389ecae321ea6c4c585b8f721b84bd64a1d.tar.gz | |
avfilter: Deduplicate default audio inputs/outputs
Lots of audio filters use very simple inputs or outputs:
An array with a single AVFilterPad whose name is "default"
and whose type is AVMEDIA_TYPE_AUDIO; everything else is unset.
Given that we never use pointer equality for inputs or outputs*,
we can simply use a single AVFilterPad instead of dozens; this
even saves .data.rel.ro (4784B here) as well as relocations.
*: In fact, several filters (like the filters in af_biquads.c)
already use the same inputs; furthermore, ff_filter_alloc()
duplicates the input and output pads so that we do not even
work with the pads directly.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavfilter/avf_showwaves.c')
| -rw-r--r-- | libavfilter/avf_showwaves.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index 7597ee2723..329753c8c8 100644 --- a/libavfilter/avf_showwaves.c +++ b/libavfilter/avf_showwaves.c @@ -794,13 +794,6 @@ static int activate(AVFilterContext *ctx) return FFERROR_NOT_READY; } -static const AVFilterPad showwaves_inputs[] = { - { - .name = "default", - .type = AVMEDIA_TYPE_AUDIO, - }, -}; - static const AVFilterPad showwaves_outputs[] = { { .name = "default", @@ -815,7 +808,7 @@ const AVFilter ff_avf_showwaves = { .init = init, .uninit = uninit, .priv_size = sizeof(ShowWavesContext), - FILTER_INPUTS(showwaves_inputs), + FILTER_INPUTS(ff_audio_default_filterpad), .activate = activate, FILTER_OUTPUTS(showwaves_outputs), FILTER_QUERY_FUNC(query_formats), |