diff options
author | Michael Niedermayer <michaelni@gmx.at> | 2013-07-10 16:39:10 +0200 |
---|---|---|
committer | Michael Niedermayer <michaelni@gmx.at> | 2013-07-10 19:07:10 +0200 |
commit | 47de8ccf426629a93f383ebcad2b7914b51a1f44 (patch) | |
tree | 796357da345b595f3a50da3b4f31db7deb418d2a /libavfilter/af_earwax.c | |
parent | 72c1de649ae92bc720268d406b16f6cdcf9ee36c (diff) | |
download | ffmpeg-47de8ccf426629a93f383ebcad2b7914b51a1f44.tar.gz |
avfilter/af_earwax: Fix out of array accesses on odd packets
Found-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit 0a3a0edd52b98aec27d1b8c63c85cb52ff46d40e)
Conflicts:
libavfilter/af_earwax.c
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavfilter/af_earwax.c')
-rw-r--r-- | libavfilter/af_earwax.c | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/libavfilter/af_earwax.c b/libavfilter/af_earwax.c index a169d2aaf1..8216b1416d 100644 --- a/libavfilter/af_earwax.c +++ b/libavfilter/af_earwax.c @@ -117,6 +117,7 @@ static int filter_frame(AVFilterLink *inlink, AVFilterBufferRef *insamples) ff_get_audio_buffer(inlink, AV_PERM_WRITE, insamples->audio->nb_samples); int ret; + int len; if (!outsamples) return AVERROR(ENOMEM); @@ -126,16 +127,20 @@ static int filter_frame(AVFilterLink *inlink, AVFilterBufferRef *insamples) out = (int16_t *)outsamples->data[0]; in = (int16_t *)insamples ->data[0]; + len = FFMIN(NUMTAPS, 2*insamples->audio->nb_samples); // copy part of new input and process with saved input - memcpy(taps+NUMTAPS, in, NUMTAPS * sizeof(*taps)); - out = scalarproduct(taps, taps + NUMTAPS, out); + memcpy(taps+NUMTAPS, in, len * sizeof(*taps)); + out = scalarproduct(taps, taps + len, out); // process current input - endin = in + insamples->audio->nb_samples * 2 - NUMTAPS; - scalarproduct(in, endin, out); - - // save part of input for next round - memcpy(taps, endin, NUMTAPS * sizeof(*taps)); + if (2*insamples->audio->nb_samples >= NUMTAPS ){ + endin = in + insamples->audio->nb_samples * 2 - NUMTAPS; + scalarproduct(in, endin, out); + + // save part of input for next round + memcpy(taps, endin, NUMTAPS * sizeof(*taps)); + } else + memmove(taps, taps + 2*insamples->audio->nb_samples, NUMTAPS * sizeof(*taps)); ret = ff_filter_frame(outlink, outsamples); avfilter_unref_buffer(insamples); |