diff options
| author | Vignesh Venkatasubramanian via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> | 2023-10-03 15:53:06 -0700 |
|---|---|---|
| committer | Ronald S. Bultje <rsbultje@gmail.com> | 2023-10-05 16:05:59 -0400 |
| commit | e8465aa5dda03b4f30d24f192ee165f88a912762 (patch) | |
| tree | 1e288433e6afcac0061638f696dac571ffa19e0d /libavcodec | |
| parent | f0f6acde1ac41b9313400463da725993cbf9b8d1 (diff) | |
| download | ffmpeg-e8465aa5dda03b4f30d24f192ee165f88a912762.tar.gz | |
avcodec/svt-av1: Set force_key_frames only when gop_size == 1
SVT-AV1 does not support requesting keyframes at arbitrary points
by setting pic_type to EB_AV1_KEY_PICTURE. So set force_key_frames
to 1 only when gop_size == 1.
Please see the comments in
https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 for a bit more
details.
Signed-off-by: Vignesh Venkatasubramanian <vigneshv@google.com>
Signed-off-by: Ronald S. Bultje <rsbultje@gmail.com>
Diffstat (limited to 'libavcodec')
| -rw-r--r-- | libavcodec/libsvtav1.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 5015169244..8d2c7f3be4 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -253,8 +253,13 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param, // In order for SVT-AV1 to force keyframes by setting pic_type to // EB_AV1_KEY_PICTURE on any frame, force_key_frames has to be set. Note // that this does not force all frames to be keyframes (it only forces a - // keyframe with pic_type is set to EB_AV1_KEY_PICTURE). - param->force_key_frames = 1; + // keyframe with pic_type is set to EB_AV1_KEY_PICTURE). As of now, SVT-AV1 + // does not support arbitrary keyframe requests by setting pic_type to + // EB_AV1_KEY_PICTURE, so it is done only when gop_size == 1. + // FIXME: When SVT-AV1 supports arbitrary keyframe requests, this code needs + // to be updated to set force_key_frames accordingly. + if (avctx->gop_size == 1) + param->force_key_frames = 1; if (avctx->framerate.num > 0 && avctx->framerate.den > 0) { param->frame_rate_numerator = avctx->framerate.num; |