aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-04-15 20:54:42 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-04-17 01:34:07 +0200
commit889ad93c8839e5ac1ec28bc8e1fea6df71b9bf80 (patch)
tree3934ce8e367bf57669fee788beee92f66258fc41 /libavcodec
parentd1e52e396b8aa778bd8d12bf25864beca0937d0a (diff)
downloadffmpeg-889ad93c8839e5ac1ec28bc8e1fea6df71b9bf80.tar.gz
fftools/ffmpeg_opt: Check attachment filesize
The data of an attachment file is put into an AVCodecParameter's extradata. The corresponding size field has type int, yet there was no check for the size to fit into an int. As a consequence, it was possible to create extradata with negative size (by using a big enough max_alloc). Other errors were also possible: If SIZE_MAX < INT64_MAX (e.g. on 32bit systems) then the file size might be truncated before the allocation; and avio_read() takes an int, too, so one would not have read as much as one desired. Furthermore, the extradata is now padded as is required. Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Diffstat (limited to 'libavcodec')
0 files changed, 0 insertions, 0 deletions