diff options
author | Ronald S. Bultje <rsbultje@gmail.com> | 2012-02-17 15:00:47 -0800 |
---|---|---|
committer | Ronald S. Bultje <rsbultje@gmail.com> | 2012-02-17 15:23:20 -0800 |
commit | 84c202cc37024bd78261e4222e46631ea73c48dd (patch) | |
tree | 8c66544aa78399182310dbc6ede9a70268265927 /libavcodec | |
parent | 07333750592e983f8c382491c48f7b402213cca9 (diff) | |
download | ffmpeg-84c202cc37024bd78261e4222e46631ea73c48dd.tar.gz |
huffyuv: error out on bit overrun.
On EOF, get_bits() will continuously return 0, causing an infinite
loop.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC: libav-stable@libav.org
Diffstat (limited to 'libavcodec')
-rw-r--r-- | libavcodec/huffyuv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/huffyuv.c b/libavcodec/huffyuv.c index ebbfc4528a..0c5f6be3b3 100644 --- a/libavcodec/huffyuv.c +++ b/libavcodec/huffyuv.c @@ -184,7 +184,7 @@ static int read_len_table(uint8_t *dst, GetBitContext *gb){ if(repeat==0) repeat= get_bits(gb, 8); //printf("%d %d\n", val, repeat); - if(i+repeat > 256) { + if(i+repeat > 256 || get_bits_left(gb) < 0) { av_log(NULL, AV_LOG_ERROR, "Error reading huffman table\n"); return -1; } |