aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec
diff options
context:
space:
mode:
authorJosh Allmann <joshua.allmann@gmail.com>2024-08-01 14:36:25 -0700
committerAnton Khirnov <anton@khirnov.net>2024-08-14 13:20:56 +0200
commit374824cbc7952e83e89725f82470275639188e5e (patch)
tree52725126b7640013e3bd073ba7655c522c88b55c /libavcodec
parent654bd47716c4f36719fb0f3f7fd8386d5ed0b916 (diff)
downloadffmpeg-374824cbc7952e83e89725f82470275639188e5e.tar.gz
avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI
Encoders may emit a buffering period SEI without a corresponding SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. During Annex B conversion, this may result in the SPS/PPS being inserted *after* the buffering period SEI but before the IDR NAL. Since the buffering period SEI references the SPS, the SPS/PPS needs to come first. Signed-off-by: Anton Khirnov <anton@khirnov.net>
Diffstat (limited to 'libavcodec')
-rw-r--r--libavcodec/bsf/h264_mp4toannexb.c15
1 files changed, 15 insertions, 0 deletions
diff --git a/libavcodec/bsf/h264_mp4toannexb.c b/libavcodec/bsf/h264_mp4toannexb.c
index 92af6a6881..dda064287e 100644
--- a/libavcodec/bsf/h264_mp4toannexb.c
+++ b/libavcodec/bsf/h264_mp4toannexb.c
@@ -30,6 +30,7 @@
#include "bytestream.h"
#include "defs.h"
#include "h264.h"
+#include "sei.h"
typedef struct H264BSFContext {
uint8_t *sps;
@@ -363,6 +364,20 @@ static int h264_mp4toannexb_filter(AVBSFContext *ctx, AVPacket *opkt)
if (!new_idr && unit_type == H264_NAL_IDR_SLICE && (buf[1] & 0x80))
new_idr = 1;
+ /* If this is a buffering period SEI without a corresponding sps/pps
+ * then prepend any existing sps/pps before the SEI */
+ if (unit_type == H264_NAL_SEI && buf[1] == SEI_TYPE_BUFFERING_PERIOD &&
+ !sps_seen && !pps_seen) {
+ if (s->sps_size) {
+ count_or_copy(&out, &out_size, s->sps, s->sps_size, PS_OUT_OF_BAND, j);
+ sps_seen = 1;
+ }
+ if (s->pps_size) {
+ count_or_copy(&out, &out_size, s->pps, s->pps_size, PS_OUT_OF_BAND, j);
+ pps_seen = 1;
+ }
+ }
+
/* prepend only to the first type 5 NAL unit of an IDR picture, if no sps/pps are already present */
if (new_idr && unit_type == H264_NAL_IDR_SLICE && !sps_seen && !pps_seen) {
if (s->sps_size)