aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec/vaapi_encode_h264.c
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-06-24 17:51:58 +0200
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2020-07-01 19:00:19 +0200
commit3cf212f6c8c7ef5cc8400510bc32045c6058893f (patch)
treef8dd239de8b754379bdba7ef109a74a63f50ad53 /libavcodec/vaapi_encode_h264.c
parent284fffa92fc54315f7974649b10a38a87f7a48ea (diff)
downloadffmpeg-3cf212f6c8c7ef5cc8400510bc32045c6058893f.tar.gz
avformat/avc, mxfenc: Avoid allocation of H264 SPS structure, fix memleak
Up until now, ff_avc_decode_sps would parse a SPS and return some properties from it in a freshly allocated structure. Yet said structure is very small and completely internal to libavformat, so there is no reason to use the heap for it. This commit therefore changes the function to return an int and to modify a caller-provided structure. This will also allow ff_avc_decode_sps to return better error codes in the future. It also fixes a memleak in mxfenc: If a packet contained multiple SPS, only the SPS structure belonging to the last SPS would be freed, the other ones would leak when the pointer is overwritten to point to the new SPS structure. Of course, without allocations there are no leaks. This is Coverity issue #1445194. Furthermore, the SPS structure has been renamed from H264SequenceParameterSet to H264SPS in order to avoid overlong lines. Reviewed-by: Tomas Härdin <tjoppen@acc.umu.se> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> (cherry picked from commit a0b6df0a3953e2586e63f513485c4d2d42507d7f) Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Diffstat (limited to 'libavcodec/vaapi_encode_h264.c')
0 files changed, 0 insertions, 0 deletions