diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2020-10-25 19:19:54 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2020-12-19 20:07:56 +0100 |
| commit | 8aadae670f28b88e94770262cd1136562bdb2f45 (patch) | |
| tree | 6d8bfdba8ff61f628a16d7f6230ae7a26142357c /libavcodec/utils.c | |
| parent | 0afbaabdca2730d3f8d88719d64802d50b92d351 (diff) | |
| download | ffmpeg-8aadae670f28b88e94770262cd1136562bdb2f45.tar.gz | |
avcodec/utils: Check bitrate for overflow in get_bit_rate()
Fixes: signed integer overflow: 617890810133996544 * 16 cannot be represented in type 'long'
Fixes: 26565/clusterfuzz-testcase-minimized-ffmpeg_dem_MV_fuzzer-5092054700654592
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavcodec/utils.c')
| -rw-r--r-- | libavcodec/utils.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 0226e36ee7..b2313860d0 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -513,7 +513,14 @@ static int64_t get_bit_rate(AVCodecContext *ctx) break; case AVMEDIA_TYPE_AUDIO: bits_per_sample = av_get_bits_per_sample(ctx->codec_id); - bit_rate = bits_per_sample ? ctx->sample_rate * (int64_t)ctx->channels * bits_per_sample : ctx->bit_rate; + if (bits_per_sample) { + bit_rate = ctx->sample_rate * (int64_t)ctx->channels; + if (bit_rate > INT64_MAX / bits_per_sample) { + bit_rate = 0; + } else + bit_rate *= bits_per_sample; + } else + bit_rate = ctx->bit_rate; break; default: bit_rate = 0; |