aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec/sonic.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2020-09-24 22:20:39 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2020-09-25 10:21:28 +0200
commitf249981976b18438cfb646183d4c21fb051e1ad4 (patch)
tree2e50fb7eea6d94d91e7359c8b796903f1754c228 /libavcodec/sonic.c
parent14d6838638f8c0dafadebe9d7cbd29a62239620c (diff)
downloadffmpeg-f249981976b18438cfb646183d4c21fb051e1ad4.tar.gz
avcodec/sonic: Check channels before deallocating
Fixes: heap-buffer-overflow Fixes: 25744/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5172961169113088 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Reviewed-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavcodec/sonic.c')
-rw-r--r--libavcodec/sonic.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c
index fa4ecc3a7a..e1d37f8780 100644
--- a/libavcodec/sonic.c
+++ b/libavcodec/sonic.c
@@ -980,9 +980,7 @@ static av_cold int sonic_decode_close(AVCodecContext *avctx)
av_freep(&s->int_samples);
av_freep(&s->tap_quant);
av_freep(&s->predictor_k);
-
- for (i = 0; i < s->channels; i++)
- {
+ for (i = 0; i < MAX_CHANNELS; i++) {
av_freep(&s->predictor_state[i]);
av_freep(&s->coded_samples[i]);
}