diff options
| author | Andreas Rheinhardt <andreas.rheinhardt@gmail.com> | 2020-07-30 13:20:09 +0200 |
|---|---|---|
| committer | Andreas Rheinhardt <andreas.rheinhardt@gmail.com> | 2020-09-18 01:47:57 +0200 |
| commit | 01dbcbb37a30b77dcdc7b2d9ed6a4fcccf4f4eec (patch) | |
| tree | 9c545ddd13430bd5fd9dd880eb12267382a6617c /libavcodec/smacker.c | |
| parent | 056a8fc07133148f6cb1f2ea157a6b91c33e5b02 (diff) | |
| download | ffmpeg-01dbcbb37a30b77dcdc7b2d9ed6a4fcccf4f4eec.tar.gz | |
avcodec/smacker: Use unsigned for shift
Given that the code currently accepts only 27 bits long Huffman codes,
the shift 1 << (length - 1) with length in 1..28 that is performed when
parsing the tree is safe. Yet if this limit were ever expanded to the
full 32 bits, this shift would be potentially undefined. So simply use
unsigned.
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Diffstat (limited to 'libavcodec/smacker.c')
| -rw-r--r-- | libavcodec/smacker.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index 9ba70af6f7..e6b163722a 100644 --- a/libavcodec/smacker.c +++ b/libavcodec/smacker.c @@ -121,7 +121,7 @@ static int smacker_decode_tree(GetBitContext *gb, HuffContext *hc, uint32_t pref r = smacker_decode_tree(gb, hc, prefix, length); if(r) return r; - return smacker_decode_tree(gb, hc, prefix | (1 << (length - 1)), length); + return smacker_decode_tree(gb, hc, prefix | (1U << (length - 1)), length); } } |