diff options
author | Niklas Haas <git@haasn.dev> | 2024-12-11 09:14:13 +0100 |
---|---|---|
committer | Niklas Haas <git@haasn.dev> | 2024-12-16 12:21:55 +0100 |
commit | ce457bfccdd2558dc0e508f2ddf9925e1b741209 (patch) | |
tree | 421eff1846ead2ffdad3d7f44fd22c78f6323418 /libavcodec/riscv/vvc | |
parent | d2096679d5b5d76a167d038a3a2aa570e4ce37f3 (diff) | |
download | ffmpeg-ce457bfccdd2558dc0e508f2ddf9925e1b741209.tar.gz |
swscale/slice: fix init of 32 bpc planes
In input.c and output.c and many other places, swscale follows the rule of using
15-bit intermediate if output bpc is <= 8, and 19-bit (inside int32_t)
intermediate otherwise. See e.g. the comments on hyScale() on
swscale_internal.h. These are also the coefficients that yuv2gbrpf32_full_X_c()
is using.
In contrast to this, the plane init code in slice.c (function fill_ones) is
assuming that we use 35-bit intermediates (inside 64-bit integers) for this
case, seemingly added by commit b4967fc71c63eae8cd96f9c46cd3e1fbd705bbf9 with
no further justification.
This causes a mismatch whenever the implicitly initialized plane contents leak
out to the output, e.g. when converting from grayscale to RGB.
Fixes: ticket #10716
Signed-off-by: Niklas Haas <git@haasn.dev>
Sponsored-by: Sovereign Tech Fund
Diffstat (limited to 'libavcodec/riscv/vvc')
0 files changed, 0 insertions, 0 deletions