diff options
| author | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2023-07-31 11:50:21 +0200 |
|---|---|---|
| committer | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | 2023-08-02 18:31:59 +0200 |
| commit | 2d7c1479c204ef2a8b9f1c0273e0e6cddd634ed5 (patch) | |
| tree | ebcbf4b45747ffafc2d96cb4e068886c8a59f6cf /libavcodec/nvenc.c | |
| parent | 28817b90fc3ea9f7d3a3a8864fdb3191cb95fe76 (diff) | |
| download | ffmpeg-2d7c1479c204ef2a8b9f1c0273e0e6cddd634ed5.tar.gz | |
avcodec/nvenc: Remove always-true check
nvenc_store_frame_data() is always called with frame != NULL
(checked at the beginning of nvenc_send_frame());
in fact, frame is dereferenced unconditionally after the block
guarded by the check for frame. Therefore Coverity complains
about this in issue #1538295.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Diffstat (limited to 'libavcodec/nvenc.c')
| -rw-r--r-- | libavcodec/nvenc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 0b6417674e..505b95f93c 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -2249,7 +2249,7 @@ static int nvenc_store_frame_data(AVCodecContext *avctx, NV_ENC_PIC_PARAMS *pic_ // in case the encoder got reconfigured, there might be leftovers av_buffer_unref(&frame_data->frame_opaque_ref); - if (frame && frame->opaque_ref && avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) { + if (frame->opaque_ref && avctx->flags & AV_CODEC_FLAG_COPY_OPAQUE) { frame_data->frame_opaque_ref = av_buffer_ref(frame->opaque_ref); if (!frame_data->frame_opaque_ref) return AVERROR(ENOMEM); |