aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec/h264.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michaelni@gmx.at>2014-03-10 18:39:02 +0100
committerMichael Niedermayer <michaelni@gmx.at>2014-03-10 18:39:02 +0100
commit5640ea43d7202e6bc6bc032079f66456323d1008 (patch)
tree88b6869c593b55a917214610557cc087a11fb007 /libavcodec/h264.c
parent15efd9a7c0a6ccc59c07c3118a2e075449c91e68 (diff)
parent2c1d84499bfe06d75e9160b824eeffd9f5587337 (diff)
downloadffmpeg-5640ea43d7202e6bc6bc032079f66456323d1008.tar.gz
Merge commit '2c1d84499bfe06d75e9160b824eeffd9f5587337' into release/0.10
* commit '2c1d84499bfe06d75e9160b824eeffd9f5587337': lagarith: pad RGB buffer by 1 byte. truemotion1: check the header size shorten: pad the internal bitstream buffer samplefmt: avoid integer overflow in av_samples_get_buffer_size() h264: Fix a typo from the previous commit h264: Lower bound check for slice offsets rpza: limit the number of blocks to the total remaining blocks in the frame Conflicts: libavcodec/lagarith.c Merged-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'libavcodec/h264.c')
-rw-r--r--libavcodec/h264.c37
1 files changed, 20 insertions, 17 deletions
diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index 9a0b07f0b0..877b0a3a7b 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -3231,8 +3231,8 @@ static int decode_slice_header(H264Context *h, H264Context *h0){
}
h->deblocking_filter = 1;
- h->slice_alpha_c0_offset = 52;
- h->slice_beta_offset = 52;
+ h->slice_alpha_c0_offset = 0;
+ h->slice_beta_offset = 0;
if( h->pps.deblocking_filter_parameters_present ) {
tmp= get_ue_golomb_31(&s->gb);
if(tmp > 2){
@@ -3243,12 +3243,16 @@ static int decode_slice_header(H264Context *h, H264Context *h0){
if(h->deblocking_filter < 2)
h->deblocking_filter^= 1; // 1<->0
- if( h->deblocking_filter ) {
- h->slice_alpha_c0_offset += get_se_golomb(&s->gb) << 1;
- h->slice_beta_offset += get_se_golomb(&s->gb) << 1;
- if( h->slice_alpha_c0_offset > 104U
- || h->slice_beta_offset > 104U){
- av_log(s->avctx, AV_LOG_ERROR, "deblocking filter parameters %d %d out of range\n", h->slice_alpha_c0_offset, h->slice_beta_offset);
+ if (h->deblocking_filter) {
+ h->slice_alpha_c0_offset = get_se_golomb(&s->gb) * 2;
+ h->slice_beta_offset = get_se_golomb(&s->gb) * 2;
+ if (h->slice_alpha_c0_offset > 12 ||
+ h->slice_alpha_c0_offset < -12 ||
+ h->slice_beta_offset > 12 ||
+ h->slice_beta_offset < -12) {
+ av_log(s->avctx, AV_LOG_ERROR,
+ "deblocking filter parameters %d %d out of range\n",
+ h->slice_alpha_c0_offset, h->slice_beta_offset);
return -1;
}
}
@@ -3277,14 +3281,12 @@ static int decode_slice_header(H264Context *h, H264Context *h0){
}
}
}
- h->qp_thresh = 15 + 52 - FFMIN(h->slice_alpha_c0_offset, h->slice_beta_offset)
- - FFMAX3(0, h->pps.chroma_qp_index_offset[0], h->pps.chroma_qp_index_offset[1])
- + 6 * (h->sps.bit_depth_luma - 8);
-
-#if 0 //FMO
- if( h->pps.num_slice_groups > 1 && h->pps.mb_slice_group_map_type >= 3 && h->pps.mb_slice_group_map_type <= 5)
- slice_group_change_cycle= get_bits(&s->gb, ?);
-#endif
+ h->qp_thresh = 15 -
+ FFMIN(h->slice_alpha_c0_offset, h->slice_beta_offset) -
+ FFMAX3(0,
+ h->pps.chroma_qp_index_offset[0],
+ h->pps.chroma_qp_index_offset[1]) +
+ 6 * (h->sps.bit_depth_luma - 8);
h0->last_slice_type = slice_type;
h->slice_num = ++h0->current_slice;
@@ -3345,7 +3347,8 @@ static int decode_slice_header(H264Context *h, H264Context *h0){
s->current_picture_ptr->field_poc[0], s->current_picture_ptr->field_poc[1],
h->ref_count[0], h->ref_count[1],
s->qscale,
- h->deblocking_filter, h->slice_alpha_c0_offset/2-26, h->slice_beta_offset/2-26,
+ h->deblocking_filter,
+ h->slice_alpha_c0_offset, h->slice_beta_offset,
h->use_weight,
h->use_weight==1 && h->use_weight_chroma ? "c" : "",
h->slice_type == AV_PICTURE_TYPE_B ? (h->direct_spatial_mv_pred ? "SPAT" : "TEMP") : ""