aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec/flacdec.c
diff options
context:
space:
mode:
authorDave Stevenson <dave.stevenson@raspberrypi.org>2019-01-17 17:39:34 +0000
committerAman Gupta <aman@tmm1.net>2019-08-23 17:07:58 -0700
commit3d857f219eb972fb345e784d17268e16b6dec6f0 (patch)
tree5e2fb93e6e33430db43d6332f9e2bd2f188a177e /libavcodec/flacdec.c
parent23a3e1460a7a609651bfe75b7b4c428eaa8f3902 (diff)
downloadffmpeg-3d857f219eb972fb345e784d17268e16b6dec6f0.tar.gz
avcodec/omx: Fix handling of fragmented buffers
See https://trac.ffmpeg.org/ticket/7687 If an encoded frame is returned split over two or more IL buffers due to the size, then there is a race between whether get_buffer will fail, return NULL, and a truncated frame is passed on, or IL will return the remaining part of the encoded frame. If get_buffer returns NULL, part of the frame is left behind in the codec, and will be collected on the next call. That then leaves a frame stuck in the codec. Repeat enough times and the codec FIFO is full, and the pipeline stalls. A performance improvement in the Raspberry Pi firmware means that the timing has changed, and now frequently drops into the case where get_buffer returns NULL. Add code such that should a buffer be received without OMX_BUFFERFLAG_ENDOFFRAME that get_buffer is called with wait set, so we wait for the remainder of the frame. This code has been made conditional on the Pi build in case other IL implementations don't handle ENDOFFRAME correctly. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org> Signed-off-by: Aman Gupta <aman@tmm1.net> Signed-off-by: Martin Storsjö <martin@martin.st>
Diffstat (limited to 'libavcodec/flacdec.c')
0 files changed, 0 insertions, 0 deletions