aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec/dca_core.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2016-12-15 01:32:18 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2017-02-04 02:27:53 +0100
commit831274fba4b14c542458ce5a3d0135b49499299a (patch)
tree13911a7ee56e512dbb8ddfa15c2d9d295f9e37c1 /libavcodec/dca_core.c
parentfd00203554334f602ee1d7c5416ff25f356f4fb7 (diff)
downloadffmpeg-831274fba4b14c542458ce5a3d0135b49499299a.tar.gz
avcodec/flacdsp: Avoid undefined operations in non debug builds
This fixes ubsan warnings in non debug builds by using unsigned operations in debug builds the correct signed operations are retained so that overflows (which should not occur in valid files and may indicate problems in the DSP code or decoder) can be detected. Alternatively they can be changed to unsigned unconditionally, then its not possible though to detect overflows easily if someone wants to test the DSP code for overflows. The 2nd alternative would be to leave the code as it is and accept that there are undefined operations in the DSP code and that ubsan output is full of them in some cases. Similar changes would be needed in some other DSP routines Suggested-by: Matt Wolenetz <wolenetz@google.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavcodec/dca_core.c')
0 files changed, 0 insertions, 0 deletions