diff options
author | Ganesh Ajjanagadde <gajjanagadde@gmail.com> | 2015-10-10 13:39:28 -0400 |
---|---|---|
committer | Ganesh Ajjanagadde <gajjanagadde@gmail.com> | 2015-10-13 19:41:07 -0400 |
commit | d59bfcd11229300182c672ca734568919a85f773 (patch) | |
tree | d2168f50031d1c0a226044321cee9c8ebd69c24d /libavcodec/allcodecs.c | |
parent | 4c8ca76965b1c29758246624940cbc529e7141f0 (diff) | |
download | ffmpeg-d59bfcd11229300182c672ca734568919a85f773.tar.gz |
avformat/mov: fix integer overflow
Partially fixes Ticket 4727.
-duration is not a safe expression, since duration can be INT_MIN.
One might ask how it can become INT_MIN.
Although it is true that line 2574 is no longer reached with INT_MIN due
to commit 053e80f6eaf8d87521fe58ea96886b6ee0bbe59d (which fixed another
integer overflow issue), mov_update_dts_shift is called on line 3549 as
well, right after a read of untrusted data.
One can do the fix locally there, but that function is already a huge
mess. Changing mov_update_dts_shift is likely better.
This changes duration to INT_MIN + 1 in such cases. This should not make any
practical difference since such streams are anyway fuzzer files.
Tested with FATE.
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
Diffstat (limited to 'libavcodec/allcodecs.c')
0 files changed, 0 insertions, 0 deletions