aboutsummaryrefslogtreecommitdiffstats
path: root/libavcodec/alac.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2019-11-08 20:40:46 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2019-12-01 17:17:04 +0100
commit7686ba1f149a94c3bac235589de8aa8db92be4e5 (patch)
tree76b86a76051ea93567cf4c247866aaeed0b6df92 /libavcodec/alac.c
parent589cb44498b5e9683c95746255a2abd6d1e74f94 (diff)
downloadffmpeg-7686ba1f149a94c3bac235589de8aa8db92be4e5.tar.gz
avcodec/alac: Fix integer overflow in lpc_prediction() with sign
Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in type 'int' Fixes: 18643/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5672182449700864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavcodec/alac.c')
-rw-r--r--libavcodec/alac.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/alac.c b/libavcodec/alac.c
index 09decb806b..d08c946249 100644
--- a/libavcodec/alac.c
+++ b/libavcodec/alac.c
@@ -227,7 +227,7 @@ static void lpc_prediction(int32_t *error_buffer, uint32_t *buffer_out,
val = d - pred[j];
sign = sign_only(val) * error_sign;
lpc_coefs[j] -= sign;
- val *= sign;
+ val *= (unsigned)sign;
error_val -= (val >> lpc_quant) * (j + 1);
}
}