diff options
| author | Martin Storsjö <martin@martin.st> | 2022-05-20 14:45:21 +0300 |
|---|---|---|
| committer | Martin Storsjö <martin@martin.st> | 2022-05-23 13:52:26 +0300 |
| commit | 4cdc14aa955805931b918d30d9c7349ab924dd52 (patch) | |
| tree | c3ff5f04579badeba3c89b3aeba0691984937c40 /fftools | |
| parent | 3fb924464244bc317a5d19ab25625ae35abde512 (diff) | |
| download | ffmpeg-4cdc14aa955805931b918d30d9c7349ab924dd52.tar.gz | |
libavutil: Deprecate av_fopen_utf8, provide an avpriv version
Since every DLL can use an individual CRT on Windows, having
an exported function that opens a FILE* won't work if that
FILE* is going to be used from a different DLL (or from user
application code).
Internally within the libraries, the issue can be worked around
by duplicating the function in all libraries (this already happened
implicitly because the function resided in file_open.c) and renaming
the function to ff_fopen_utf8 (so that it doesn't end up exported from
the DLLs) and duplicating it in all libraries that use it.
This makes the avpriv_fopen_utf8 / ff_fopen_utf8 function work in
the exact same way as the existing avpriv_open / ff_open, with the
same setup as introduced in e743e7ae6ee7e535c4394bec6fe6650d2b0dbf65.
That mechanism doesn't work for external users, thus deprecate the
existing function.
Signed-off-by: Martin Storsjö <martin@martin.st>
Diffstat (limited to 'fftools')
| -rw-r--r-- | fftools/fopen_utf8.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fftools/fopen_utf8.h b/fftools/fopen_utf8.h index db57fcaec4..cd18fe8ce1 100644 --- a/fftools/fopen_utf8.h +++ b/fftools/fopen_utf8.h @@ -21,7 +21,7 @@ #include <stdio.h> -/* The fopen_utf8 function here is essentially equivalent to av_fopen_utf8, +/* The fopen_utf8 function here is essentially equivalent to avpriv_fopen_utf8, * except that it doesn't set O_CLOEXEC, and that it isn't exported * from a different library. (On Windows, each DLL might use a different * CRT, and FILE* handles can't be shared across them.) */ |