diff options
| author | Marton Balint <cus@passwd.hu> | 2024-03-17 23:35:24 +0100 |
|---|---|---|
| committer | Marton Balint <cus@passwd.hu> | 2024-03-25 21:30:51 +0100 |
| commit | 5df901ffa56e0ff225fcc129c751befeb3b4d0d0 (patch) | |
| tree | 4f48e7e648f2abf5fb9c8230e24a32437c549ea5 /doc | |
| parent | 7c003b63c85aadf57ca10be849bd9895a4eeeb87 (diff) | |
| download | ffmpeg-5df901ffa56e0ff225fcc129c751befeb3b4d0d0.tar.gz | |
avutil/timestamp: introduce av_ts_make_time_string2 for better precision
av_ts_make_time_string() used "%.6g" format, but this format was losing
precision even when the timestamp to be printed was not that large. For example
for 3 hours (10800) seconds, only 1 decimal digit was printed, which made this
format inaccurate when it was used in e.g. the silencedetect filter. Other
detection filters printing timestamps had similar issues. Also time base
parameter of the function was *AVRational instead of AVRational.
Resolve these problems by introducing a new function, av_ts_make_time_string2().
We change the used format to "%.*f", use a precision of 6, except when printing
values near 0, in which case we calculate the precision dynamically to aim for
a similar precision in normal form as with %.6g. No longer using scientific
representation can make parsing the timestamp easier for the users, we can
safely do this because the theoretical maximum of INT64_MAX*INT32_MAX still
fits into the string buffer in normal form.
We somewhat imitate %g by trimming ending zeroes and the potential decimal
point characters. In order not to trim "inf" as well, we assume that the
decimal point string does not contain the letter "f". Note that depending on
printf %f implementation, we might trim "infinity" to "inf".
Thanks for Allan Cady for bringing up this issue.
Signed-off-by: Marton Balint <cus@passwd.hu>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/APIchanges | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/doc/APIchanges b/doc/APIchanges index 7762907255..38fbfcca20 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,11 @@ The last version increases of all libraries were on 2024-03-07 API changes, most recent first: +2024-03-xx - xxxxxxxxxx - lavu 59.7.100 - timestamp.h + Add av_ts_make_time_string2() for better timestamp precision, the new + function accepts AVRational as time base instead of *AVRational, and is not + an inline function like its predecessor. + 2024-03-xx - xxxxxxxxxx - lavu 59.6.100 - film_grain_params.h Add av_film_grain_params_select(). |