aboutsummaryrefslogtreecommitdiffstats
path: root/doc/transforms.md
diff options
context:
space:
mode:
authorGuangyu Sun <sunguangyucn@gmail.com>2021-07-07 08:41:32 -0700
committerLynne <dev@lynne.ee>2021-07-12 09:54:47 +0200
commit75510d7015f108b84dd3be3c903afa710997d719 (patch)
treedb7d8785dd1e98a5d57859d9341bd0d6114734ee /doc/transforms.md
parented240db9e3122d4dccbd1bee7d12cd50a0edc807 (diff)
downloadffmpeg-75510d7015f108b84dd3be3c903afa710997d719.tar.gz
avformat/oggparsevorbis: Update end_trimming for the last packet
Without end_trimming, the last packet will contain unexpected samples used for padding. This commit partially fixes #6367 when the audio length is long enough. dd if=/dev/zero of=./silence.raw count=20 bs=500 oggenc --raw silence.raw --output=silence.ogg oggdec --raw --output silence.oggdec.raw silence.ogg ffmpeg -codec:a libvorbis -i silence.ogg -f s16le -codec:a pcm_s16le silence.libvorbis.ffmpeg.raw ffmpeg -i silence.ogg -f s16le -codec:a pcm_s16le silence.native.ffmpeg.raw ls -l *.raw The original test case in #6367 is still not fixed due to a remaining issue. The remaining issue is that ogg_stream->private is not kept during ogg_save()/ogg_restore(). Field final_duration in the private data is important to calculate end_trimming. Some common operations such as avformat_open_input() and avformat_find_stream_info() before reading packet will trigger ogg_save() and ogg_restore(). Luckily, final_duration will not get updated until the last ogg page. The save/restore mentioned above will not change final_duration most of the time. But if the audio length is short, those reads may be performed on the last ogg page, causing trouble keeping the correct value of final_duration. We probably need a more complicated patch to address this issue. Signed-off-by: Guangyu Sun <gsun@roblox.com>
Diffstat (limited to 'doc/transforms.md')
0 files changed, 0 insertions, 0 deletions