diff options
| author | Matt Wolenetz <wolenetz@chromium.org> | 2016-11-21 15:54:02 -0800 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2016-12-30 00:11:18 +0100 |
| commit | fe7547d69e6721d064c8604d0a6375a2d24b35ca (patch) | |
| tree | 71b62def439222f68fcc5b416f2561cc06f73e27 | |
| parent | 9ec52a0a9b086d8a916a580ad594c126cd810a45 (diff) | |
| download | ffmpeg-fe7547d69e6721d064c8604d0a6375a2d24b35ca.tar.gz | |
lavf/utils.c Protect against accessing entries[nb_entries]
In ff_index_search_timestamp(), if b == num_entries,
m == num_entries - 1, and entries[m].flags & AVINDEX_DISCARD_FRAME is
true, then the search for the next non-discarded packet could access
entries[nb_entries], exceeding its bounds. This change adds a protection
against that scenario. Reference: https://crbug.com/666770
Reviewed-by: Sasi Inguva <isasi@google.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavformat/utils.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavformat/utils.c b/libavformat/utils.c index 50a30f6942..d5dfca7dec 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1981,7 +1981,7 @@ int ff_index_search_timestamp(const AVIndexEntry *entries, int nb_entries, m = (a + b) >> 1; // Search for the next non-discarded packet. - while ((entries[m].flags & AVINDEX_DISCARD_FRAME) && m < b) { + while ((entries[m].flags & AVINDEX_DISCARD_FRAME) && m < b && m < nb_entries - 1) { m++; if (m == b && entries[m].timestamp >= wanted_timestamp) { m = b - 1; |