diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2019-11-08 20:40:46 +0100 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2019-12-06 20:30:58 +0100 |
| commit | fcc8c187fbdead5fa1b2973aee0f4e1fe2f06d34 (patch) | |
| tree | bcdb68afa74b420459515533814a847c3cff727a | |
| parent | 50dfc2dbf95a576ac6c9da794da5c4fa9e153655 (diff) | |
| download | ffmpeg-fcc8c187fbdead5fa1b2973aee0f4e1fe2f06d34.tar.gz | |
avcodec/alac: Fix integer overflow in lpc_prediction() with sign
Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in type 'int'
Fixes: 18643/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5672182449700864
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 7686ba1f149a94c3bac235589de8aa8db92be4e5)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/alac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 1a6ab56f90..f60fcfcd9a 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -223,7 +223,7 @@ static void lpc_prediction(int32_t *error_buffer, uint32_t *buffer_out, val = d - pred[j]; sign = sign_only(val) * error_sign; lpc_coefs[j] -= sign; - val *= sign; + val *= (unsigned)sign; error_val -= (val >> lpc_quant) * (j + 1); } } |