aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOctavio Alvarez <octalffdev@alvarezp.org>2019-03-27 22:52:32 -0600
committerCarl Eugen Hoyos <ceffmpeg@gmail.com>2019-04-06 15:20:36 +0200
commitf4f40cbb578a09319f9ddafc80388a5556ec7713 (patch)
tree577bc0d0a36596f02c0c8f0041ea4d4445e63755
parent772c73e61f5df3b37b4b227bdf8e93035f8f7daa (diff)
downloadffmpeg-f4f40cbb578a09319f9ddafc80388a5556ec7713.tar.gz
lavd/x11grab: fix vertical repositioning
There is a calculation error in xcbgrab_reposition() that breaks vertical repositioning on follow_mouse. It made the bottom reposition occur when moving the mouse lower than N pixels after the capture bottom edge, instead of before. This commit fixes the calculation to match the documentation. follow_mouse: centered or number of pixels. The documentation says: When it is specified with "centered", the grabbing region follows the mouse pointer and keeps the pointer at the center of region; otherwise, the region follows only when the mouse pointer reaches within PIXELS (greater than zero) to the edge of region.
-rw-r--r--libavdevice/xcbgrab.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c
index 6d142abd4f..b7e689343e 100644
--- a/libavdevice/xcbgrab.c
+++ b/libavdevice/xcbgrab.c
@@ -127,7 +127,7 @@ static int xcbgrab_reposition(AVFormatContext *s,
int left = x + f;
int right = x + w - f;
int top = y + f;
- int bottom = y + h + f;
+ int bottom = y + h - f;
if (p_x > right) {
x += p_x - right;
} else if (p_x < left) {