diff options
| author | Michael Niedermayer <michael@niedermayer.cc> | 2018-07-22 21:26:24 +0200 |
|---|---|---|
| committer | Michael Niedermayer <michael@niedermayer.cc> | 2018-07-28 14:35:50 +0200 |
| commit | f457c0ad7f73e31e99761f2ad3738cf3b3c24ca0 (patch) | |
| tree | 1ead3bf11198746fcdc42ed7675def53fed6a2d2 | |
| parent | 462d1be6dec5ff4768be8c202f359cbf037db3c6 (diff) | |
| download | ffmpeg-f457c0ad7f73e31e99761f2ad3738cf3b3c24ca0.tar.gz | |
avcodec/diracdec: Check slice numbers for overflows in relation to picture dimensions
Fixes: signed integer overflow: 88 * 33685506 cannot be represented in type 'int'
Fixes: 9433/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-5725943535501312
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
| -rw-r--r-- | libavcodec/diracdec.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index 4ef1b3ea9b..b27c743c58 100644 --- a/libavcodec/diracdec.c +++ b/libavcodec/diracdec.c @@ -1243,7 +1243,10 @@ static int dirac_unpack_idwt_params(DiracContext *s) else { s->num_x = get_interleaved_ue_golomb(gb); s->num_y = get_interleaved_ue_golomb(gb); - if (s->num_x * s->num_y == 0 || s->num_x * (uint64_t)s->num_y > INT_MAX) { + if (s->num_x * s->num_y == 0 || s->num_x * (uint64_t)s->num_y > INT_MAX || + s->num_x * (uint64_t)s->avctx->width > INT_MAX || + s->num_y * (uint64_t)s->avctx->height > INT_MAX + ) { av_log(s->avctx,AV_LOG_ERROR,"Invalid numx/y\n"); s->num_x = s->num_y = 0; return AVERROR_INVALIDDATA; |