summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLidong Yan <[email protected]>2025-06-17 22:14:15 +0800
committerJames Almer <[email protected]>2025-06-17 11:27:28 -0300
commitee1f79b0fa4c82da9c19328b049b593c71611402 (patch)
tree61b2c17ca70d2c6b2864d58e2a7f33780c8c367b
parent8087777e667cfcf42fb647d8ed8500b1feed270b (diff)
avformat/sbgdec: fix leak in sbg_read_header()
In sbg_read_header(), if avformat_new_stream() failed, it returns without cleanup, which may cause memory leaks. Replace return statement with goto so that we would first clean up then return. Signed-off-by: Lidong Yan <[email protected]> Reviewed-by: Nicolas George <[email protected]> Signed-off-by: James Almer <[email protected]>
-rw-r--r--libavformat/sbgdec.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/libavformat/sbgdec.c b/libavformat/sbgdec.c
index bf319be228..4afb51b844 100644
--- a/libavformat/sbgdec.c
+++ b/libavformat/sbgdec.c
@@ -1434,8 +1434,10 @@ static av_cold int sbg_read_header(AVFormatContext *avf)
}
st = avformat_new_stream(avf, NULL);
- if (!st)
- return AVERROR(ENOMEM);
+ if (!st) {
+ r = AVERROR(ENOMEM);
+ goto fail;
+ }
sti = ffstream(st);
st->codecpar->codec_type = AVMEDIA_TYPE_AUDIO;
st->codecpar->codec_id = AV_CODEC_ID_FFWAVESYNTH;