aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenoit Fouet <benoit.fouet@free.fr>2014-09-23 10:07:10 +0200
committerMichael Niedermayer <michaelni@gmx.at>2014-10-03 03:40:59 +0200
commited9c6529f032b16c8a94ff70caea2e17a4e68f99 (patch)
treecacdf7ae06b84b4fd7237f4ee24a2db0c430014c
parentaa40bbb492afc2c5e043999b1a291b7507fdcb7d (diff)
downloadffmpeg-ed9c6529f032b16c8a94ff70caea2e17a4e68f99.tar.gz
avformat/riffenc: Filter out "BottomUp" in ff_put_bmp_header()
Fixes Ticket1304 Commit message and extradata size bugfix by commiter Signed-off-by: Michael Niedermayer <michaelni@gmx.at> (cherry picked from commit 6843b9dc78bc966bb30121828ef4f6b6755cf877) Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
-rw-r--r--libavformat/riffenc.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c
index ef4d399030..2eb2ae1d0e 100644
--- a/libavformat/riffenc.c
+++ b/libavformat/riffenc.c
@@ -209,11 +209,15 @@ int ff_put_wav_header(AVIOContext *pb, AVCodecContext *enc, int flags)
void ff_put_bmp_header(AVIOContext *pb, AVCodecContext *enc,
const AVCodecTag *tags, int for_asf, int ignore_extradata)
{
+ int keep_height = enc->extradata_size >= 9 &&
+ !memcmp(enc->extradata + enc->extradata_size - 9, "BottomUp", 9);
+ int extradata_size = enc->extradata_size - 9*keep_height;
+
/* size */
- avio_wl32(pb, 40 + (ignore_extradata ? 0 : enc->extradata_size));
+ avio_wl32(pb, 40 + (ignore_extradata ? 0 :extradata_size));
avio_wl32(pb, enc->width);
//We always store RGB TopDown
- avio_wl32(pb, enc->codec_tag ? enc->height : -enc->height);
+ avio_wl32(pb, enc->codec_tag || keep_height ? enc->height : -enc->height);
/* planes */
avio_wl16(pb, 1);
/* depth */
@@ -227,9 +231,9 @@ void ff_put_bmp_header(AVIOContext *pb, AVCodecContext *enc,
avio_wl32(pb, 0);
if (!ignore_extradata) {
- avio_write(pb, enc->extradata, enc->extradata_size);
+ avio_write(pb, enc->extradata, extradata_size);
- if (!for_asf && enc->extradata_size & 1)
+ if (!for_asf && extradata_size & 1)
avio_w8(pb, 0);
}
}