diff options
| author | Anton Khirnov <anton@khirnov.net> | 2015-03-07 22:06:59 +0100 |
|---|---|---|
| committer | Reinhard Tartler <siretart@tauware.de> | 2015-03-08 22:04:40 -0400 |
| commit | eb9041403d820634c45ed4ee98570246a252507a (patch) | |
| tree | 00a92bb93f3fca5c35775436840904bbf96ebdd2 | |
| parent | 0051174c70810b66378cf8ea093eab01302f6049 (diff) | |
| download | ffmpeg-eb9041403d820634c45ed4ee98570246a252507a.tar.gz | |
tiff: Check that there is no aliasing in pixel format selection
Fixes possible issues with unexpected bpp/bppcount values.
CC: libav-stable@libav.org
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Bug-Id: CVE-2014-8544
(cherry picked from commit ae5e1f3d663a8c9a532d89e588cbc61f171c9186)
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
| -rw-r--r-- | libavcodec/tiff.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 7fb0e7a3a6..164cfce49c 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -270,6 +270,14 @@ static int init_image(TiffContext *s, AVFrame *frame) int i, ret; uint32_t *pal; + // make sure there is no aliasing in the following switch + if (s->bpp >= 100 || s->bppcount >= 10) { + av_log(s->avctx, AV_LOG_ERROR, + "Unsupported image parameters: bpp=%d, bppcount=%d\n", + s->bpp, s->bppcount); + return AVERROR_INVALIDDATA; + } + switch (s->bpp * 10 + s->bppcount) { case 11: s->avctx->pix_fmt = AV_PIX_FMT_MONOBLACK; |