aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2022-09-18 19:14:07 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2022-11-03 23:29:55 +0100
commite4c5c904932b2ddc1f2c7b2e38ddf1fdaba09875 (patch)
tree4ec4c03cca0ce4410b3be9fa2a373d4a3a707e02
parent2376a4d5a78d46f45b6171f2a856f01ac80923cb (diff)
downloadffmpeg-e4c5c904932b2ddc1f2c7b2e38ddf1fdaba09875.tar.gz
avformat/vividas: Check packet size
Fixes: signed integer overflow: 119760682 - -2084600173 cannot be represented in type 'int' Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-6745781167587328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 5f44489cc5d4f3767f6ad2ad067ee6a3f78374bb) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavformat/vividas.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/libavformat/vividas.c b/libavformat/vividas.c
index d7a6e74650..2668f93f06 100644
--- a/libavformat/vividas.c
+++ b/libavformat/vividas.c
@@ -682,6 +682,7 @@ static int viv_read_packet(AVFormatContext *s,
if (viv->sb_entries[viv->current_sb_entry].flag == 0) {
uint64_t v_size = ffio_read_varlen(pb);
+ int last = 0, last_start;
if (!viv->num_audio)
return AVERROR_INVALIDDATA;
@@ -705,12 +706,18 @@ static int viv_read_packet(AVFormatContext *s,
if (i > 0 && start == 0)
break;
+ if (start < last)
+ return AVERROR_INVALIDDATA;
viv->n_audio_subpackets = i + 1;
+ last =
viv->audio_subpackets[i].start = start;
viv->audio_subpackets[i].pcm_bytes = pcm_bytes;
}
+ last_start =
viv->audio_subpackets[viv->n_audio_subpackets].start = (int)(off - avio_tell(pb));
+ if (last_start < last)
+ return AVERROR_INVALIDDATA;
viv->current_audio_subpacket = 0;
} else {